Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2851003002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, subresource-filter-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, Peter Beverloo, tbansal+watch-data-reduction-proxy_chromium.org, jam, timvolodine, darin-cc_chromium.org, ios-reviews_chromium.org, grt+watch_chromium.org, gcasto+watchlist_chromium.org, harkness+watch_chromium.org, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2851003002 Cr-Commit-Position: refs/heads/master@{#468654} Committed: https://chromium.googlesource.com/chromium/src/+/8945fc9391e28e47d7b948907f7ae76b1b3e33b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_use_measurement/core/data_use_measurement.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/data_use_measurement/core/data_use_measurement_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/data_use_measurement/core/data_use_network_delegate_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/renderer_context_menu/context_menu_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/safe_browsing/base_ui_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sessions/content/content_live_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_live_tab.mm View 2 chunks +2 lines, -1 line 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/user_prefs/user_prefs.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/user_prefs/user_prefs.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/zoom/zoom_event_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:21:31 UTC) #6
Avi (use Gerrit)
ping
3 years, 7 months ago (2017-05-02 01:31:20 UTC) #7
sdefresne
lgtm (sorry, Monday was a public holiday)
3 years, 7 months ago (2017-05-02 13:15:39 UTC) #8
Avi (use Gerrit)
On 2017/05/02 13:15:39, sdefresne wrote: > lgtm (sorry, Monday was a public holiday) Eeek, was ...
3 years, 7 months ago (2017-05-02 15:04:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851003002/1
3 years, 7 months ago (2017-05-02 15:05:00 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:03:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8945fc9391e28e47d7b948907f7a...

Powered by Google App Engine
This is Rietveld 408576698