Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2850983002: Remove UserGestureUtilizedCallback, it's unused outside of tests (Closed)

Created:
3 years, 7 months ago by Nate Chapin
Modified:
3 years, 7 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews-html_chromium.org, feature-media-reviews_chromium.org, sof, eae+blinkwatch, feature-vr-reviews_chromium.org, hongchan, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, blink-reviews-frames_chromium.org, Raymond Toy, kinuko+watch, rwlbuis, mustaq
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove UserGestureUtilizedCallback, it's unused outside of tests BUG= Review-Url: https://codereview.chromium.org/2850983002 Cr-Commit-Position: refs/heads/master@{#468371} Committed: https://chromium.googlesource.com/chromium/src/+/46577d66405c2b6d3fd7e490733a24b3c59a7a3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -164 lines) Patch
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/UserGestureIndicator.h View 4 chunks +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/platform/UserGestureIndicator.cpp View 4 chunks +3 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp View 8 chunks +10 lines, -83 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nate Chapin
rbyers: PTAL Looks like the last live usage of UserGestureUtilizedCallback was deleted in https://chromium.googlesource.com/chromium/src/+/60b7754704a8fd81b0a010ce253b3754e72c50ec, this ...
3 years, 7 months ago (2017-04-28 23:27:33 UTC) #4
Rick Byers
OK LGTM I had left it there thinking we might have cases in the future ...
3 years, 7 months ago (2017-04-29 02:44:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850983002/1
3 years, 7 months ago (2017-05-01 17:15:15 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:50:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46577d66405c2b6d3fd7e490733a...

Powered by Google App Engine
This is Rietveld 408576698