Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2850953002: Add a unit test for "ALREADY_SAVED" being converted to "SUCCESS" (Closed)

Created:
3 years, 7 months ago by Pete Williamson
Modified:
3 years, 7 months ago
Reviewers:
romax
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a unit test for "ALREADY_SAVED" being converted to "SUCCESS" We recently made a change to treat the MHTML page already being saved to success, and we added a unit test for the background loader offliner, but didn't add one for the prerendering offliner. This adds the test for the prerendering offliner. BUG=715152 Review-Url: https://codereview.chromium.org/2850953002 Cr-Commit-Position: refs/heads/master@{#468181} Committed: https://chromium.googlesource.com/chromium/src/+/d33a171b7c308a64dc3372fac3da2179c63b419e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Pete Williamson
3 years, 7 months ago (2017-04-28 21:52:02 UTC) #2
romax
lgtm
3 years, 7 months ago (2017-04-28 22:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850953002/1
3 years, 7 months ago (2017-04-28 23:30:19 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:36:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d33a171b7c308a64dc3372fac3da...

Powered by Google App Engine
This is Rietveld 408576698