Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2850933002: kernel backend impact - noSuchMethod helpers are passed a Map literal (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

kernel backend impact - noSuchMethod helpers are passed a Map literal Fixes a regression on ~150 tests. Will be replaced with kernel_impact. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/41ca7f8bf5067993b460a1851a3bcaace5a9e6ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -160 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -152 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 7 months ago (2017-04-28 21:12:03 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-04-28 21:15:28 UTC) #4
sra1
3 years, 7 months ago (2017-04-28 21:26:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41ca7f8bf5067993b460a1851a3bcaace5a9e6ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698