Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2850933002: kernel backend impact - noSuchMethod helpers are passed a Map literal (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_helpers.impact; 5 library dart2js.js_helpers.impact;
6 6
7 import '../common/names.dart'; 7 import '../common/names.dart';
8 import '../common_elements.dart' show CommonElements, ElementEnvironment; 8 import '../common_elements.dart' show CommonElements, ElementEnvironment;
9 import '../elements/types.dart' show InterfaceType; 9 import '../elements/types.dart' show InterfaceType;
10 import '../elements/entities.dart'; 10 import '../elements/entities.dart';
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 _commonElements.unresolvedTopLevelSetterError, 217 _commonElements.unresolvedTopLevelSetterError,
218 _commonElements.symbolConstructor, 218 _commonElements.symbolConstructor,
219 ] 219 ]
220 : [ 220 : [
221 _commonElements.throwNoSuchMethod, 221 _commonElements.throwNoSuchMethod,
222 ], 222 ],
223 otherImpacts: [ 223 otherImpacts: [
224 // Also register the types of the arguments passed to this method. 224 // Also register the types of the arguments passed to this method.
225 _needsList( 225 _needsList(
226 'Needed to encode the arguments for throw NoSuchMethodError.'), 226 'Needed to encode the arguments for throw NoSuchMethodError.'),
227 _needsString('Needed to encode the name for throw NoSuchMethodError.') 227 _needsString(
228 'Needed to encode the name for throw NoSuchMethodError.'),
229 mapLiteralClass, // noSuchMethod helpers are passed a Map.
228 ]); 230 ]);
229 } 231 }
230 232
231 BackendImpact _stringValues; 233 BackendImpact _stringValues;
232 234
233 BackendImpact get stringValues { 235 BackendImpact get stringValues {
234 return _stringValues ??= 236 return _stringValues ??=
235 new BackendImpact(instantiatedClasses: [_commonElements.jsStringClass]); 237 new BackendImpact(instantiatedClasses: [_commonElements.jsStringClass]);
236 } 238 }
237 239
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 /// Backend impact for type variables through mirrors. 789 /// Backend impact for type variables through mirrors.
788 BackendImpact get typeVariableMirror { 790 BackendImpact get typeVariableMirror {
789 return _typeVariableMirror ??= new BackendImpact(staticUses: [ 791 return _typeVariableMirror ??= new BackendImpact(staticUses: [
790 _commonElements.typeVariableConstructor, 792 _commonElements.typeVariableConstructor,
791 _commonElements.createRuntimeType 793 _commonElements.createRuntimeType
792 ], instantiatedClasses: [ 794 ], instantiatedClasses: [
793 _commonElements.typeVariableClass 795 _commonElements.typeVariableClass
794 ]); 796 ]);
795 } 797 }
796 } 798 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698