Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 2850923002: Mark waterfall-images.html as failure (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark waterfall-images.html as failure Per request here: http://crbug.com/714166 R=dgozman BUG=714166, 715405 Review-Url: https://codereview.chromium.org/2850923002 Cr-Commit-Position: refs/heads/master@{#468431} Committed: https://chromium.googlesource.com/chromium/src/+/920c268621477bdfa16464d0b8ef915703eacb00

Patch Set 1 #

Total comments: 1

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
allada
I will fix it after products comes out of experiments.
3 years, 7 months ago (2017-04-28 20:44:11 UTC) #1
dgozman
https://codereview.chromium.org/2850923002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2850923002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode3440 third_party/WebKit/LayoutTests/TestExpectations:3440: crbug.com/715405 [ Win Mac ] virtual/mojo-loading/http/tests/inspector/network/waterfall-images.html [ Failure ] ...
3 years, 7 months ago (2017-04-28 20:47:07 UTC) #2
allada
PTaL
3 years, 7 months ago (2017-04-28 23:04:38 UTC) #4
dgozman
lgtm
3 years, 7 months ago (2017-05-01 18:35:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850923002/20001
3 years, 7 months ago (2017-05-01 20:29:50 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:48:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/920c268621477bdfa16464d0b8ef...

Powered by Google App Engine
This is Rietveld 408576698