Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2850873002: Disable flaky NQE test in Cronet (Closed)

Created:
3 years, 7 months ago by tbansal1
Modified:
3 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, mgersh
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky NQE test in Cronet Disable flaky NetworkQualityEstimator (NQE) test in Cronet. Also, rename a few NQE tests. BUG=710626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2850873002 Cr-Commit-Position: refs/heads/master@{#468342} Committed: https://chromium.googlesource.com/chromium/src/+/228ebf10b2054a06baf2bffcdb0825ddecdc96ae

Patch Set 1 : Rebased #

Patch Set 2 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -200 lines) Patch
M components/cronet/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 6 chunks +0 lines, -200 lines 0 comments Download
A components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java View 1 1 chunk +233 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
tbansal1
xunjieli: ptal. Thanks.
3 years, 7 months ago (2017-04-28 20:26:42 UTC) #10
xunjieli
Tarun, since you are here, would you be willing to move NQE-specific tests to a ...
3 years, 7 months ago (2017-04-28 20:45:22 UTC) #11
tbansal1
On 2017/04/28 20:45:22, xunjieli wrote: > Tarun, since you are here, would you be willing ...
3 years, 7 months ago (2017-04-29 01:00:23 UTC) #15
tbansal1
ptal. Thanks.
3 years, 7 months ago (2017-04-29 01:00:34 UTC) #16
xunjieli
On 2017/04/29 01:00:34, tbansal1 wrote: > ptal. Thanks. lgtm!
3 years, 7 months ago (2017-05-01 13:28:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850873002/80001
3 years, 7 months ago (2017-05-01 16:25:49 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:26:14 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/228ebf10b2054a06baf2bffcdb08...

Powered by Google App Engine
This is Rietveld 408576698