Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2850853002:
Fix compile targets in Linux Clang Analyzer recipe. (Closed)
|
Created:
3 years, 7 months ago by Kevin M Modified:
3 years, 7 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix compile targets in Linux Clang Analyzer recipe.
Change compile targets for Linux Clang Analyzer from "all" to "chrome".
R=dpranke@chromium.org
BUG=689095
Review-Url: https://codereview.chromium.org/2850853002
Cr-Commit-Position: refs/heads/master@{#469383}
Committed: https://chromium.googlesource.com/chromium/src/+/f63fc2cdc8d74b1bd251b7bf98720675e5a8f817
Patch Set 1 #
Total comments: 1
Patch Set 2 : Buildtarget => chrome #Messages
Total messages: 21 (10 generated)
The CQ bit was checked by kmarshall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
https://codereview.chromium.org/2850853002/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (left): https://codereview.chromium.org/2850853002/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:10654: }, How does this know to build 'chrome'? If the answer is "because of the way things are configured in the build repo", that's the wrong answer :). We should change it so that "chrome" is specified here and nothing is specified there.
Done here.
Description was changed from ========== Remove "all" compile target from Linux Clang Analyzer recipe. Remove "all" compile target from Linux Clang Analyzer buildbot recipe. The buildbot should only be compiling "chrome". R=dpranke@chromium.org BUG=689095 ========== to ========== Fix compile targets in Linux Clang Analyzer recipe. Change compile targets for Linux Clang Analyzer from "all" to "chrome". R=dpranke@chromium.org BUG=689095 ==========
lgtm :). Thanks!
Here's the build CL: https://chromium-review.googlesource.com/c/495468/
Thanks!
The CQ bit was checked by kmarshall@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kmarshall@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493916925429920,
"parent_rev": "13f3aa8a8bcc07bd5a23f4bb1cac65fd82da9038", "commit_rev":
"f63fc2cdc8d74b1bd251b7bf98720675e5a8f817"}
Message was sent while issue was closed.
Description was changed from ========== Fix compile targets in Linux Clang Analyzer recipe. Change compile targets for Linux Clang Analyzer from "all" to "chrome". R=dpranke@chromium.org BUG=689095 ========== to ========== Fix compile targets in Linux Clang Analyzer recipe. Change compile targets for Linux Clang Analyzer from "all" to "chrome". R=dpranke@chromium.org BUG=689095 Review-Url: https://codereview.chromium.org/2850853002 Cr-Commit-Position: refs/heads/master@{#469383} Committed: https://chromium.googlesource.com/chromium/src/+/f63fc2cdc8d74b1bd251b7bf9872... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f63fc2cdc8d74b1bd251b7bf9872... |
