Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 2850833002: Replace ASSERT_NOT_REACHED with NOTREACHED in bindings/ (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in bindings/ BUG=708056 Review-Url: https://codereview.chromium.org/2850833002 Cr-Commit-Position: refs/heads/master@{#468503} Committed: https://chromium.googlesource.com/chromium/src/+/3f3bcd31ce23e2008493305d47ff67d208dae95a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
pilgrim_google
3 years, 7 months ago (2017-04-28 17:14:55 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-04-29 02:13:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850833002/1
3 years, 7 months ago (2017-05-01 20:07:55 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:25:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f3bcd31ce23e2008493305d47ff...

Powered by Google App Engine
This is Rietveld 408576698