Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2850813002: Rename AccountManagerHelper.mAccountManager field to mDelegate (Closed)

Created:
3 years, 7 months ago by bsazonov
Modified:
3 years, 7 months ago
Reviewers:
msarda
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AccountManagerHelper.mAccountManager field to mDelegate This CL fixes confusing field name. Field has AccountManagerDelegate type and should be named accordinly. BUG=698258 Review-Url: https://codereview.chromium.org/2850813002 Cr-Commit-Position: refs/heads/master@{#468016} Committed: https://chromium.googlesource.com/chromium/src/+/8ccdc38b5dce12724f37cb1b9161be646258ab42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java View 9 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bsazonov
Mihai, please take a look.
3 years, 7 months ago (2017-04-28 13:53:45 UTC) #2
msarda
lgtm
3 years, 7 months ago (2017-04-28 15:36:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850813002/1
3 years, 7 months ago (2017-04-28 15:49:56 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 15:55:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ccdc38b5dce12724f37cb1b9161...

Powered by Google App Engine
This is Rietveld 408576698