Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2850783002: Dart SDK Spelling b, c, and d. (Closed)

Created:
3 years, 7 months ago by erikcorry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org, dart-fe-team+reviews_google.com, Cutch, dart-uxr+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -267 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/mac/chrome_mac.croc View 1 chunk +1 line, -1 line 0 comments Download
M build/win/chrome_win.croc View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/input_converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/stress/utilities/server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/codegen/text_formatter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/kernel/ast_from_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/README.md View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/placeholder_safety.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/doc/GENERIC_METHODS.md View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/codegen/BenchmarkBase.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/foreign_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/DeltaBlue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/frontend/super_initializers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/treeshaker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/run_tests.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/helpers/tag.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/globals.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/random_walk_fuzzer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/third_party/binary_size/src/template/D3SymbolTreeMap.js View 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/bignum-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/strtod.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/constants_dbc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/cpu_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/isolate_reload.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/kernel_to_il.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/redundancy_elimination.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timer.h View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/SwarmApp.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/Views.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/GridLayout.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/observable/ChangeEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/observable/EventBatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/TimeUtil.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_names.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 16 chunks +16 lines, -16 lines 0 comments Download
M sdk/lib/internal/sort.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/process.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/benchmark_smoke/benchmark_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/deferred_inline_restrictions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/deferred_split_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/js_array_index_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/js_array_removeLast_error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_constructor_name_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/corelib/regexp/ranges-and-escaped-hyphens_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/regexp/regress-regexp-codeflush_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/sort_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/throw_half_surrogate_pair_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/regexp/ranges-and-escaped-hyphens_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/regexp/regress-regexp-codeflush_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/sort_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib_strong/throw_half_surrogate_pair_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_typed_interop_anonymous_unreachable_exp_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_typed_interop_anonymous_unreachable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/window_nosuchmethod_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/function_send_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inferrer_named_parameter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/string_optimizations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/if_conversion_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_29137_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/fannkuch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/inferrer_named_parameter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/string_optimizations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/intercept_schedule_microtask2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/mirrors_reader.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/mirrors_used_typedef_declaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/async/intercept_schedule_microtask2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/html/js_typed_interop_anonymous_unreachable_exp_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/html/js_typed_interop_anonymous_unreachable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/mirrors/mirrors_reader.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/mirrors/mirrors_used_typedef_declaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/docs/docs.json View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/idlparser.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/KeyboardEventStream.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 8 chunks +8 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/dependency_graph.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 7 months ago (2017-04-28 11:50:18 UTC) #1
Kevin Millikin (Google)
LGTM.
3 years, 7 months ago (2017-04-28 14:31:00 UTC) #2
erikcorry
3 years, 7 months ago (2017-05-01 06:28:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
aa6353b6da65eab616828ec710f9a6510619ab32.

Powered by Google App Engine
This is Rietveld 408576698