Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

Clusterfuzz found a sample where
CompositeEditCommand::MoveParagraphWithClones() moves |before_paragraph|
out of the DOM tree after moving the paragraph. This patch uses
RelocatablePosition to track |before_paragraph| and |after_paragraph| so
that the positions we track are always connected.

Note: CompositeEditCommand::MoveParagraphs() is already using
RelocatablePosition to track positions before and after the moved
paragraphs.

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote

Review-Url: https://codereview.chromium.org/2850773003
Cr-Commit-Position: refs/heads/master@{#468278}
Committed: https://chromium.googlesource.com/chromium/src/+/a4e8fc5aeabab79dd84a7ced4b7c433a428864a5

[Xiaocheng, 2017-04-29 03:44:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 03:44:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-29 03:47:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 03:47:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-29 03:51:39]

Description was changed from

==========
Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote
==========

to

==========
Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

Clusterfuzz found a sample where
CompositeEditCommand::MoveParagraphWithClones() moves |before_paragraph|
out of the DOM tree after moving the paragraph. This patch uses
RelocatablePosition to track |before_paragraph| and |after_paragraph| so
that the positions we track are always connected.

Note: CompositeEditCommand::MoveParagraphs() is already using
RelocatablePosition to track positions before and after the moved
paragraphs.

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote
==========

[Xiaocheng, 2017-04-29 03:52:08]

xiaochengh@chromium.org changed reviewers:
+ kojii@chromium.org

[Xiaocheng, 2017-04-29 03:52:09]

PTAL, as yosin@ and tkent@ are both OOO...

[commit-bot: I haz the power, 2017-04-29 05:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 05:38:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-01 01:57:03]

kojii@chromium.org changed reviewers:
+ tkent@chromium.org

[kojii, 2017-05-01 01:57:04]

tkent@, PTAL. I can only RS this change.

[tkent, 2017-05-01 02:19:32]

lgtm

[Xiaocheng, 2017-05-01 02:30:18]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-05-01 02:30:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 04:11:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493605818043680,
"parent_rev": "e15ff1b5a013329a42aa8b8feb6d8d0faf16b0d0", "commit_rev":
"a4e8fc5aeabab79dd84a7ced4b7c433a428864a5"}

[commit-bot: I haz the power, 2017-05-01 04:11:51]

Description was changed from

==========
Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

Clusterfuzz found a sample where
CompositeEditCommand::MoveParagraphWithClones() moves |before_paragraph|
out of the DOM tree after moving the paragraph. This patch uses
RelocatablePosition to track |before_paragraph| and |after_paragraph| so
that the positions we track are always connected.

Note: CompositeEditCommand::MoveParagraphs() is already using
RelocatablePosition to track positions before and after the moved
paragraphs.

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote
==========

to

==========
Use RelocatablePosition in CompositeEditCommand::MoveParagraphWithClones

Clusterfuzz found a sample where
CompositeEditCommand::MoveParagraphWithClones() moves |before_paragraph|
out of the DOM tree after moving the paragraph. This patch uses
RelocatablePosition to track |before_paragraph| and |after_paragraph| so
that the positions we track are always connected.

Note: CompositeEditCommand::MoveParagraphs() is already using
RelocatablePosition to track positions before and after the moved
paragraphs.

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote

Review-Url: https://codereview.chromium.org/2850773003
Cr-Commit-Position: refs/heads/master@{#468278}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4e8fc5aeabab79dd84a7ced4b7c...
==========

[commit-bot: I haz the power, 2017-05-01 04:11:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4e8fc5aeabab79dd84a7ced4b7c...