Test Variations GPOS mark to base placement

Test Variations GPOS mark to base placement

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG=693065
R=behdad, kojii

Review-Url: https://codereview.chromium.org/2850743002
Cr-Commit-Position: refs/heads/master@{#468276}
Committed: https://chromium.googlesource.com/chromium/src/+/0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7

[drott, 2017-04-28 06:56:33]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 06:57:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-04-28 08:14:25]

Description was changed from

==========
wip gpos reftest

gpos reftest

BUG=
==========

to

==========
Test Variations GPOS mark to base placement

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG=693065
R=behdad, kojii
==========

[drott, 2017-04-28 08:14:25]

drott@chromium.org changed reviewers:
+ behdad@chromium.org, kojii@chromium.org

[drott, 2017-04-28 08:19:24]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 08:19:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-04-28 08:19:56]

drott@chromium.org changed reviewers:
+ eae@chromium.org

[commit-bot: I haz the power, 2017-04-28 09:46:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 09:46:05]

Dry run: This issue passed the CQ dry run.

[behdad_google, 2017-04-28 18:21:55]

behdad@google.com changed reviewers:
+ behdad@google.com

[behdad_google, 2017-04-28 18:21:55]

lgtm

[drott, 2017-04-29 01:58:44]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:59:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 01:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 01:59:07]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[kojii, 2017-05-01 02:10:29]

lgtm, this is so great! Sorry for late review.

[kojii, 2017-05-01 02:10:33]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-01 02:10:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 03:44:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493604633610420,
"parent_rev": "40a4cdf946305d99ce988d67b17602454b01c1a3", "commit_rev":
"0b70e87ed73d1b64b4ba9acbc4615b6fba7094f7"}

[commit-bot: I haz the power, 2017-05-01 03:45:07]

Description was changed from

==========
Test Variations GPOS mark to base placement

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG=693065
R=behdad, kojii
==========

to

==========
Test Variations GPOS mark to base placement

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG=693065
R=behdad, kojii

Review-Url: https://codereview.chromium.org/2850743002
Cr-Commit-Position: refs/heads/master@{#468276}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b70e87ed73d1b64b4ba9acbc461...
==========

[commit-bot: I haz the power, 2017-05-01 03:45:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0b70e87ed73d1b64b4ba9acbc461...

[eae, 2017-05-01 16:43:20]

LGTM!