Remove BitmapArray.

Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509
Review-Url: https://codereview.chromium.org/2850733003
Cr-Commit-Position: refs/heads/master@{#468725}
Committed: https://chromium.googlesource.com/chromium/src/+/76d6d9c5e3be62df7beb5f047e26b292997904de

[Elliot Glaysher, 2017-04-28 20:05:56]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 20:07:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-28 20:13:51]

Description was changed from

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509

Remove last real bitmap_array usage.
==========

to

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509
==========

[commit-bot: I haz the power, 2017-04-28 20:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:22:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Elliot Glaysher, 2017-04-28 20:25:28]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 20:26:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-04-28 21:01:18]

erg@chromium.org changed reviewers:
+ rjkroege@chromium.org

[Elliot Glaysher, 2017-04-28 21:01:18]

Now that cursors no longer use BitmapArray, I went and changed over the last
consumer so it can be deleted.

[commit-bot: I haz the power, 2017-04-28 22:24:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:24:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rjkroege, 2017-05-02 17:18:14]

On 2017/04/28 21:01:18, Elliot Glaysher wrote:
> Now that cursors no longer use BitmapArray, I went and changed over the last
> consumer so it can be deleted.

Presumably the implementation of the mojom in DrmThread::SetCursor doesn't need
to be adjusted because the array mapping code is just doing the right thing?

lgtm

[Elliot Glaysher, 2017-05-02 17:23:18]

On 2017/05/02 17:18:14, rjkroege wrote:
> On 2017/04/28 21:01:18, Elliot Glaysher wrote:
> > Now that cursors no longer use BitmapArray, I went and changed over the last
> > consumer so it can be deleted.
> 
> Presumably the implementation of the mojom in DrmThread::SetCursor doesn't
need
> to be adjusted because the array mapping code is just doing the right thing?

Correct. array<SkBitmap> resolves to const std::vector<SkBitmap>&.

[Elliot Glaysher, 2017-05-02 17:30:41]

Description was changed from

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509
==========

to

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509
==========

[Elliot Glaysher, 2017-05-02 17:30:41]

erg@chromium.org changed reviewers:
+ thakis@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2017-05-02 17:31:14]

tsepez: mojom security

thakis: file deletion in skia/public/interfaces

[Tom Sepez, 2017-05-02 17:38:38]

lgtm

RS

[Nico, 2017-05-02 17:44:21]

lgtm

[Elliot Glaysher, 2017-05-02 17:46:24]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:46:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 18:54:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493747184467080,
"parent_rev": "8b24c49c7e35918e4aa21ba770e0e0bc54c8dd0c", "commit_rev":
"76d6d9c5e3be62df7beb5f047e26b292997904de"}

[commit-bot: I haz the power, 2017-05-02 18:55:29]

Description was changed from

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509
==========

to

==========
Remove BitmapArray.

This changes the last consumer of skia.mojom.BitmapArray to a normal
array<skia.mojom.Bitmap>, and deletes BitmapArray now that the vector
mapping code works automatically.

BUG=624509

Review-Url: https://codereview.chromium.org/2850733003
Cr-Commit-Position: refs/heads/master@{#468725}
Committed:
https://chromium.googlesource.com/chromium/src/+/76d6d9c5e3be62df7beb5f047e26...
==========

[commit-bot: I haz the power, 2017-05-02 18:55:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76d6d9c5e3be62df7beb5f047e26...