[Payment Request] Updates PaymentRequestUpdateEvent.updateWith function

[Payment Request] Updates PaymentRequestUpdateEvent.updateWith function

Updates the updateWith function to accept an instance of
window.PaymentDetails as well as a promise that fulfills with one:
https://w3c.github.io/browser-payment-api/#paymentrequestupdateevent-interface

BUG=602666
Review-Url: https://codereview.chromium.org/2850723003
Cr-Commit-Position: refs/heads/master@{#467985}
Committed: https://chromium.googlesource.com/chromium/src/+/5b56f229932277a95f08420e0d2031656d66e471

[Moe, 2017-04-28 09:15:59]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2017-04-28 09:16:19]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-04-28 09:16:19]

Hi Rouslan, Please take a look.

[commit-bot: I haz the power, 2017-04-28 09:16:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 09:27:20]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-04-28 13:07:23]

lgtm % nit

https://codereview.chromium.org/2850723003/diff/1/ios/chrome/browser/web/reso...
File ios/chrome/browser/web/resources/payment_request.js (right):

https://codereview.chromium.org/2850723003/diff/1/ios/chrome/browser/web/reso...
ios/chrome/browser/web/resources/payment_request.js:239:
__gCrWeb['paymentRequestManager'].updateWith = function(detailsPromise) {
Nit: Please change this parameter name to "detailsOrPromise".

[Moe, 2017-04-28 13:40:43]

Thanks.

https://codereview.chromium.org/2850723003/diff/1/ios/chrome/browser/web/reso...
File ios/chrome/browser/web/resources/payment_request.js (right):

https://codereview.chromium.org/2850723003/diff/1/ios/chrome/browser/web/reso...
ios/chrome/browser/web/resources/payment_request.js:239:
__gCrWeb['paymentRequestManager'].updateWith = function(detailsPromise) {
On 2017/04/28 13:07:23, ಠ_ಠ wrote:
> Nit: Please change this parameter name to "detailsOrPromise".

Done.

[Moe, 2017-04-28 13:40:46]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-04-28 13:40:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2850723003/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-04-28 13:41:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:10:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493386846712020,
"parent_rev": "927053fa078035ee9bea31ef77184ccbe8001745", "commit_rev":
"5b56f229932277a95f08420e0d2031656d66e471"}

[commit-bot: I haz the power, 2017-04-28 14:11:02]

Description was changed from

==========
[Payment Request] Updates PaymentRequestUpdateEvent.updateWith function

Updates the updateWith function to accept an instance of
window.PaymentDetails as well as a promise that fulfills with one:
https://w3c.github.io/browser-payment-api/#paymentrequestupdateevent-interface

BUG=602666
==========

to

==========
[Payment Request] Updates PaymentRequestUpdateEvent.updateWith function

Updates the updateWith function to accept an instance of
window.PaymentDetails as well as a promise that fulfills with one:
https://w3c.github.io/browser-payment-api/#paymentrequestupdateevent-interface

BUG=602666

Review-Url: https://codereview.chromium.org/2850723003
Cr-Commit-Position: refs/heads/master@{#467985}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b56f229932277a95f08420e0d20...
==========

[commit-bot: I haz the power, 2017-04-28 14:11:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b56f229932277a95f08420e0d20...