Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2850723002: Update add user button dynamically after policy push (Closed)

Created:
3 years, 7 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 7 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update add user button dynamically after policy push Using UpdateUIState() is insufficient because it does not have the mechanism to change 'add button disabled' state back to 'not disabled'. We should explicitly call UpdateAddButtonStatus(). BUG=411618 Review-Url: https://codereview.chromium.org/2850723002 Cr-Commit-Position: refs/heads/master@{#467910} Committed: https://chromium.googlesource.com/chromium/src/+/3b2bedb7d1ae06640fbc94359ff66b9008842bca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Wenzhao (Colin) Zang
3 years, 7 months ago (2017-04-27 23:17:16 UTC) #3
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-04-28 04:14:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850723002/1
3 years, 7 months ago (2017-04-28 05:13:58 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:51:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b2bedb7d1ae06640fbc94359ff6...

Powered by Google App Engine
This is Rietveld 408576698