Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2850703002: Revert of CQ: start draining CQ. (Closed)

Created:
3 years, 7 months ago by tandrii(chromium)
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, dpranke, Bons
CC:
chromium-reviews, shinyak+cc_chromium.com, tikuta+cc_chromium.com, ukai+cc_chromium.com, yyanagisawa+cc_chromium.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CQ: start draining CQ. (patchset #1 id:1 of https://codereview.chromium.org/2850553003/ ) Reason for revert: CQ draining actually doesn't work :( Original issue's description: > CQ: start draining CQ. > > TBR=dpranke@chromium.org,andybons@chromium.org > NOTRY=True > NOPRESUBMIT=True > BUG=716089 > > Review-Url: https://codereview.chromium.org/2850553003 > Cr-Commit-Position: refs/heads/master@{#467795} > Committed: https://chromium.googlesource.com/chromium/src/+/ae8025b8658d55b0f6b74956f1b2381695a3c991 R=dpranke@google.com TBR=andybons@chromium.org, dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716089 Review-Url: https://codereview.chromium.org/2850703002 . Cr-Commit-Position: refs/heads/master@{#467797} Committed: https://chromium.googlesource.com/chromium/src/+/6bed808f4f908b11571245ae50a40215d6862fa5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tandrii(chromium)
Created Revert of CQ: start draining CQ.
3 years, 7 months ago (2017-04-27 22:05:26 UTC) #2
tandrii(chromium)
Right, so I can't land with CQ this because CQ is broken until this lands.
3 years, 7 months ago (2017-04-27 22:11:59 UTC) #3
dpranke
lgtm
3 years, 7 months ago (2017-04-27 22:19:23 UTC) #5
tandrii(chromium)
3 years, 7 months ago (2017-04-27 22:23:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bed808f4f908b11571245ae50a40215d6862fa5 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698