Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org

Review-Url: https://codereview.chromium.org/2850683002
Cr-Commit-Position: refs/heads/master@{#468163}
Committed: https://chromium.googlesource.com/chromium/src/+/6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb

[robliao, 2017-04-27 21:12:57]

Description was changed from

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
==========

to

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robliao, 2017-04-27 21:13:09]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:13:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-04-27 22:11:08]

Description was changed from

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
are only 2 instances of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robliao, 2017-04-27 22:11:21]

Description was changed from

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
are only 2 instances of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robliao, 2017-04-27 23:09:14]

robliao@chromium.org changed reviewers:
+ scottmg@chromium.org

[robliao, 2017-04-27 23:09:27]

scottmg: Please review this CL. Thanks!

[scottmg, 2017-04-27 23:16:07]

lgtm

https://codereview.chromium.org/2850683002/diff/1/base/win/scoped_comptr.h
File base/win/scoped_comptr.h (right):

https://codereview.chromium.org/2850683002/diff/1/base/win/scoped_comptr.h#ne...
base/win/scoped_comptr.h:239: ScopedComPtrRef(T* scoped_com_ptr) :
scoped_com_ptr_(scoped_com_ptr) {}
explicit

[robliao, 2017-04-28 17:50:21]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:51:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2017-04-28 17:53:14]

robliao@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dmazzoni@chromium.org, thakis@chromium.org,
waffles@chromium.org, wez@chromium.org

[robliao, 2017-04-28 17:53:40]

Description was changed from

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org
==========

[robliao, 2017-04-28 17:54:51]

Reviewers: There are two types of changes in this CL. You'll find your username
under the types of changes. Please review the paths under your name. Thanks!

Less Mechanical Changes:

dmazzoni:
  content/browser/accessibility/accessibility_win_browsertest.cc

waffles:
  components/update_client/background_downloader_win.cc



Mechanical Changes (TBR):

dalecurtis:
  media/*

thakis:
  chrome/*
  ui/*

wez:
  remoting/*

[Sergey Ulanov, 2017-04-28 17:58:17]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2017-04-28 17:58:18]

remoting lgtm

[DaleCurtis, 2017-04-28 18:10:29]

lgtm

[Sorin Jianu, 2017-04-28 18:20:13]

sorin@chromium.org changed reviewers:
+ sorin@chromium.org

[Sorin Jianu, 2017-04-28 18:20:14]

lgtm

thank you!

components/update_client/ lgtm

[waffles, 2017-04-28 18:38:08]

lgtm

[Nico, 2017-04-28 20:33:09]

rs-lgtm

[commit-bot: I haz the power, 2017-04-28 22:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:14:45]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-28 22:21:25]

lgtm for accessibility_win_browsertest.cc

[robliao, 2017-04-28 22:33:24]

The CQ bit was checked by robliao@chromium.org

[robliao, 2017-04-28 22:33:25]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2850683002/#ps20001
(title: "Add Explicit")

[commit-bot: I haz the power, 2017-04-28 22:34:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:41:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493418804585160,
"parent_rev": "6f3dbad75c5dd6c1bc915d8baf96a36d102f8fad", "commit_rev":
"6fc41c68172a8f2644faef0a8deb6d8a7eb1aafb"}

[commit-bot: I haz the power, 2017-04-28 22:41:41]

Description was changed from

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org
==========

to

==========
Remove ScopedComPtr::ReceiveVoid and Add ScopedComPtrRef

Since there is no equivalent of ScopedComPtr::ReceiveVoid in ComPtr,
we have to mimic ComPtrRef and add ScopedComPtrRef to get the same
convenient void** access. This does introduce some complications for
uses of ScopedComPtr<T>* in templates and in concrete types, but there
aren't very many of those.

BUG=638327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org, thakis@chromium.org, wez@chromium.org

Review-Url: https://codereview.chromium.org/2850683002
Cr-Commit-Position: refs/heads/master@{#468163}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fc41c68172a8f2644faef0a8deb...
==========

[commit-bot: I haz the power, 2017-04-28 22:41:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fc41c68172a8f2644faef0a8deb...