Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2850673003: MD Bookmarks: Fix sidebar min/max width and Add dialog text (Closed)

Created:
3 years, 7 months ago by tsergeant
Modified:
3 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Fix sidebar min/max width and Add dialog text * Fixes an issue from crrev.com/467567, where it was possible to resize the sidebar without any limits on minimum or maximum width. * Fixes an issue from crrev.com/467582, where text was colored white incorrectly in the bookmark add dialog. BUG=692844 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2850673003 Cr-Commit-Position: refs/heads/master@{#467900} Committed: https://chromium.googlesource.com/chromium/src/+/dbd0203fc10fbaeae74d56a90f78bc9ec71809cd

Patch Set 1 #

Patch Set 2 : Fix add dialog as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/resources/md_bookmarks/app.html View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.html View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
tsergeant
3 years, 7 months ago (2017-04-28 01:02:20 UTC) #3
tsergeant
Oops, seems like we had a buggy day yesterday. Just added a new patchset which ...
3 years, 7 months ago (2017-04-28 01:29:56 UTC) #6
calamity
lgtm
3 years, 7 months ago (2017-04-28 04:56:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850673003/20001
3 years, 7 months ago (2017-04-28 05:20:55 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:27:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbd0203fc10fbaeae74d56a90f78...

Powered by Google App Engine
This is Rietveld 408576698