Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2850663002: MD-Settings - Add test for federated password dialog. (Closed)

Created:
3 years, 7 months ago by hcarmona
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-Settings - Add test for federated password dialog. Followup for http://crrev.com/2844553003 R=dbeam@chromium.org BUG=706310 Review-Url: https://codereview.chromium.org/2850663002 Cr-Commit-Position: refs/heads/master@{#468020} Committed: https://chromium.googlesource.com/chromium/src/+/119717035c2dc30d8602465cbc1428eb72072c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/test/data/webui/settings/settings_passwords_section_browsertest.js View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hcarmona
PTAL, followup w/ test to CL in passwords dialog.
3 years, 7 months ago (2017-04-27 23:38:10 UTC) #5
Dan Beam
yay! lgtm!
3 years, 7 months ago (2017-04-28 01:34:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850663002/1
3 years, 7 months ago (2017-04-28 16:16:39 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:22:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/119717035c2dc30d8602465cbc14...

Powered by Google App Engine
This is Rietveld 408576698