Enable NetProxyPreconnects experiment by default

Enable NetProxyPreconnects experiment by default

Final experiment results here: https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041
Review-Url: https://codereview.chromium.org/2850653002
Cr-Commit-Position: refs/heads/master@{#468354}
Committed: https://chromium.googlesource.com/chromium/src/+/c418f3faea4a20e5512f1e0f45338e54d3e1f4a5

[tbansal1, 2017-04-27 21:01:29]

Description was changed from

==========
Enable preconnect restrict by default

BUG=
==========

to

==========
Enable preconnect restrict by default

BUG=682041
==========

[tbansal1, 2017-04-27 21:02:04]

Description was changed from

==========
Enable preconnect restrict by default

BUG=682041
==========

to

==========
Enable NetProxyPreconnects experiment by default

BUG=682041
==========

[tbansal1, 2017-04-27 21:02:11]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:02:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 21:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:29:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tbansal1, 2017-04-27 21:59:20]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:59:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-04-27 22:03:02]

Description was changed from

==========
Enable NetProxyPreconnects experiment by default

BUG=682041
==========

to

==========
Enable NetProxyPreconnects experiment by default

Final experiment results here:
https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041
==========

[tbansal1, 2017-04-27 22:03:10]

tbansal@chromium.org changed reviewers:
+ rch@chromium.org, xunjieli@chromium.org

[tbansal1, 2017-04-27 22:03:11]

xunjieli, rch: ptal. Thanks.

[commit-bot: I haz the power, 2017-04-27 22:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:52:40]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[xunjieli, 2017-04-28 14:24:31]

lgtm mod two comments below.

https://codereview.chromium.org/2850653002/diff/1/components/network_session_...
File components/network_session_configurator/network_session_configurator.cc
(right):

https://codereview.chromium.org/2850653002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:367:
&proxy_preconnects_trial_params);
Can we get rid of line 365 - 367?

https://codereview.chromium.org/2850653002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/2850653002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl.cc:313: // (probably via some other job).
Could you link crbug.com/682041 in this comment?

[tbansal1, 2017-04-28 16:35:47]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-04-28 16:36:09]

rch: ptal. Thanks.

https://codereview.chromium.org/2850653002/diff/1/components/network_session_...
File components/network_session_configurator/network_session_configurator.cc
(right):

https://codereview.chromium.org/2850653002/diff/1/components/network_session_...
components/network_session_configurator/network_session_configurator.cc:367:
&proxy_preconnects_trial_params);
On 2017/04/28 14:24:30, xunjieli wrote:
> Can we get rid of line 365 - 367?

Good catch. Done.

https://codereview.chromium.org/2850653002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/2850653002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl.cc:313: // (probably via some other job).
On 2017/04/28 14:24:31, xunjieli wrote:
> Could you link crbug.com/682041 in this comment?

Done.

[Ryan Hamilton, 2017-05-01 02:14:06]

lgtm

[tbansal1, 2017-05-01 06:13:42]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 06:13:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 07:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 07:19:47]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-05-01 16:20:06]

tbansal@chromium.org changed reviewers:
+ isherman@chromium.org

[tbansal1, 2017-05-01 16:20:07]

isherman: PTAL at testing/variations/fieldtrial_testing_config.json. Thanks!

[Ilya Sherman, 2017-05-01 17:58:56]

fieldtrial changes lgtm

[tbansal1, 2017-05-01 18:00:27]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-05-01 18:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2850653002/#ps40001
(title: "xunjieli comments")

[commit-bot: I haz the power, 2017-05-01 18:01:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:08:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493661627591440,
"parent_rev": "da1b049fa7cad45f62965d461c5119a48775ab38", "commit_rev":
"c418f3faea4a20e5512f1e0f45338e54d3e1f4a5"}

[commit-bot: I haz the power, 2017-05-01 18:08:38]

Description was changed from

==========
Enable NetProxyPreconnects experiment by default

Final experiment results here:
https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041
==========

to

==========
Enable NetProxyPreconnects experiment by default

Final experiment results here:
https://bugs.chromium.org/p/chromium/issues/detail?id=682041#c18

BUG=682041

Review-Url: https://codereview.chromium.org/2850653002
Cr-Commit-Position: refs/heads/master@{#468354}
Committed:
https://chromium.googlesource.com/chromium/src/+/c418f3faea4a20e5512f1e0f4533...
==========

[commit-bot: I haz the power, 2017-05-01 18:08:40]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c418f3faea4a20e5512f1e0f4533...