[Home] Don't cache FadingBackgroundView

[Home] Don't cache FadingBackgroundView

There's a report of a crash when trying to disable the fading
background view during ChromeHomeNewTabPage creation. This change
adds a null check and retrieves the fading background view from
the activity each time it is neeed rather than caching.

BUG=716015
Review-Url: https://codereview.chromium.org/2850623003
Cr-Commit-Position: refs/heads/master@{#467835}
Committed: https://chromium.googlesource.com/chromium/src/+/58bde56a7498151dccab27864c6beb20daf7ff45

[Theresa, 2017-04-27 22:22:41]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2017-04-27 22:23:13]

twellington@chromium.org changed reviewers:
+ dgn@chromium.org

[Theresa, 2017-04-27 22:23:13]

ptal

[commit-bot: I haz the power, 2017-04-27 22:29:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-04-27 22:40:30]

lgtm

[Theresa, 2017-04-27 22:51:43]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2017-04-27 22:51:43]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:52:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:09:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493333503878970, "parent_rev":
"043d55636176cf1c5f9b0ff29c9c853bb538dbd5", "commit_rev":
"58bde56a7498151dccab27864c6beb20daf7ff45"}

[commit-bot: I haz the power, 2017-04-28 02:09:14]

Description was changed from

==========
[Home] Don't cache FadingBackgroundView

There's a report of a crash when trying to disable the fading
background view during ChromeHomeNewTabPage creation. This change
adds a null check and retrieves the fading background view from
the activity each time it is neeed rather than caching.

BUG=716015
==========

to

==========
[Home] Don't cache FadingBackgroundView

There's a report of a crash when trying to disable the fading
background view during ChromeHomeNewTabPage creation. This change
adds a null check and retrieves the fading background view from
the activity each time it is neeed rather than caching.

BUG=716015

Review-Url: https://codereview.chromium.org/2850623003
Cr-Commit-Position: refs/heads/master@{#467835}
Committed:
https://chromium.googlesource.com/chromium/src/+/58bde56a7498151dccab27864c6b...
==========

[commit-bot: I haz the power, 2017-04-28 02:09:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58bde56a7498151dccab27864c6b...