[DevTools] Cleanup overlay resources in Dispose

[DevTools] Cleanup overlay resources in Dispose

This is a speculative attempt to fight memory regression after
recent overlay refactoring. I suspect that InspectorOverlayAgent
is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate.

This patch tries to clean them up in Dispose and ensure that
nothing will be created after that point (disposed_ field).

BUG=715266
Review-Url: https://codereview.chromium.org/2850623002
Cr-Commit-Position: refs/heads/master@{#467927}
Committed: https://chromium.googlesource.com/chromium/src/+/4bf230386429b68cd02e0b1cb8450691f525fc04

[dgozman, 2017-04-27 20:40:43]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-04-27 20:40:56]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-04-27 20:40:57]

Could you please take a look?

[commit-bot: I haz the power, 2017-04-27 20:41:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:56:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:56:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2017-04-27 21:42:33]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:43:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq1, 2017-04-27 22:28:50]

caseq@google.com changed reviewers:
+ caseq@google.com

[caseq1, 2017-04-27 22:28:51]

lgtm

[commit-bot: I haz the power, 2017-04-28 01:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:36:36]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-28 07:56:41]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:56:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 08:01:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493366201182100, "parent_rev":
"bc40747b23fee88ab7f819ae697268edf8b6b4ab", "commit_rev":
"4bf230386429b68cd02e0b1cb8450691f525fc04"}

[commit-bot: I haz the power, 2017-04-28 08:02:31]

Description was changed from

==========
[DevTools] Cleanup overlay resources in Dispose

This is a speculative attempt to fight memory regression after
recent overlay refactoring. I suspect that InspectorOverlayAgent
is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate.

This patch tries to clean them up in Dispose and ensure that
nothing will be created after that point (disposed_ field).

BUG=715266
==========

to

==========
[DevTools] Cleanup overlay resources in Dispose

This is a speculative attempt to fight memory regression after
recent overlay refactoring. I suspect that InspectorOverlayAgent
is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate.

This patch tries to clean them up in Dispose and ensure that
nothing will be created after that point (disposed_ field).

BUG=715266

Review-Url: https://codereview.chromium.org/2850623002
Cr-Commit-Position: refs/heads/master@{#467927}
Committed:
https://chromium.googlesource.com/chromium/src/+/4bf230386429b68cd02e0b1cb845...
==========

[commit-bot: I haz the power, 2017-04-28 08:02:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bf230386429b68cd02e0b1cb845...