Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2850613002: Revert of HttpCache::Transaction layer allowing parallel validation (patchset #33 id:800001 of http… (Closed)

Created:
3 years, 7 months ago by shivanisha
Modified:
3 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/branch-heads/3082
Project:
chromium
Visibility:
Public.

Description

Revert of HttpCache::Transaction layer allowing parallel validation (patchset #33 id:800001 of https://codereview.chromium.org/2721933002/ ) Reason for revert: Breaks tricky-tot-chrome-pfq-informational audio_CrasSanity autotest: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/4271 TBR=asanka@chromium.org,jkarlin@chromium.org BUG=715913 Original issue's description: > This CL is a precursor to allowing shared writing to fix cache lock. > > This CL allows transactions to continue to their validation phase even when another > transaction is the active reader/writer. After the validation phase, if its a match > the transaction might wait till the response is written to the cache by the active > writer. If its not a match the transaction will doom the entry and go to the > network. In a subsequent CL, the not matching case will create a new entry as well. > > BUG=472740 > > Review-Url: https://codereview.chromium.org/2721933002 > Cr-Commit-Position: refs/heads/master@{#467426} > Committed: https://chromium.googlesource.com/chromium/src/+/1e2e347f957ef889aaee527bb757849f76e8a808 TBR=asanka@chromium.org,jkarlin@chromium.org,rdsmith@chromium.org,shivanisha@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472740 Review-Url: https://codereview.chromium.org/2847653002 Cr-Commit-Position: refs/heads/master@{#467556} (cherry picked from commit ae7fa093c74907efb6c2788208ac05495e960936) Review-Url: https://codereview.chromium.org/2850613002 Cr-Commit-Position: refs/branch-heads/3082@{#3} Cr-Branched-From: 190ee07cecf53e3795197cc195b844f7cc15a9ea-refs/heads/master@{#467534} Committed: https://chromium.googlesource.com/chromium/src/+/0e97dc17b154f15e5566ac5079548402ab02e238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -1159 lines) Patch
M net/http/http_cache.h View 4 chunks +21 lines, -110 lines 0 comments Download
M net/http/http_cache.cc View 9 chunks +117 lines, -253 lines 0 comments Download
M net/http/http_cache_transaction.h View 5 chunks +1 line, -17 lines 0 comments Download
M net/http/http_cache_transaction.cc View 46 chunks +81 lines, -184 lines 0 comments Download
M net/http/http_cache_unittest.cc View 13 chunks +66 lines, -516 lines 0 comments Download
M net/http/http_transaction_test_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M net/http/mock_http_cache.h View 2 chunks +0 lines, -10 lines 0 comments Download
M net/http/mock_http_cache.cc View 2 chunks +0 lines, -42 lines 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
shivanisha
Merging into branch 3082
3 years, 7 months ago (2017-04-27 19:42:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850613002/1
3 years, 7 months ago (2017-04-27 19:42:48 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:04:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e97dc17b154f15e5566ac507954...

Powered by Google App Engine
This is Rietveld 408576698