Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=

Review-Url: https://codereview.chromium.org/2850573002
Cr-Commit-Position: refs/heads/master@{#468142}
Committed: https://chromium.googlesource.com/chromium/src/+/127c6abecca77a09866078eb781645ba9aea32d7

[Fan Yang, 2017-04-27 16:37:29]

Description was changed from

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.


Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.

Merge internal change: 154330328

Include "base/macros.h" in quic_mutex.h


Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE frame every
20 packets which do not have retransmittble frames.

Merge internal change: 154290226

In QUIC v39, read and write integers and floating numbers in big endian.

Merge internal change: 154287990

Make QuicSession::OnFinalByteOffsetReceived virtual.

Merge internal change: 154212957

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.

Merge internal change: 154129181

QUIC: correctly update local stream state on receipt of trailers after sending
RST. Protected by FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers

Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).

Merge internal change: 154081704

Delete QUIC/SPDY utility methods for parsing headers/trailers. These are no
longer used (outside of tests). Not used in Chromium either.

Merge internal change: 154068097

Remove unused packet parameter from QuicTimeWaitListManager::ProcessPacket.

Merge internal change: 153857099

Remove unused packet_number parameter from multiple functions in QUIC.

Merge internal change: 153847178

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.

Merge internal change: 153829126

Some changes to prepare for endian change for QUIC: 1) Make data reader/write be
able to read/write integers and floating numbers in big endian. 2) Make data
reader/write be able to read/write 24/40/48/56-bit integers. 3) Add functions to
read/write QuicPacketNumber, QuicStreamId, QuicStreamOffset in QuicFramer.

No functional change expected. Not protected.

Merge internal change: 153820887

Remove std::move from return statements.

Merge internal change: 153819488

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.

BUG=
==========

[Fan Yang, 2017-04-27 16:38:00]

Description was changed from

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

BUG=
==========

[Fan Yang, 2017-04-27 16:41:53]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 16:42:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-04-27 16:47:35]

fayang@chromium.org changed reviewers:
+ zhongyi@chromium.org

[commit-bot: I haz the power, 2017-04-27 17:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 17:03:06]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Zhongyi Shi, 2017-04-27 17:46:43]

Before I start to review your merge CL list, could you update your cl
description to list the CLs in a descending order? We run "git log
--pretty=medium net/quic | grep -i -A 100 'Landing Recent QUIC changes' | grep
-i 'Merge internal change' | head -n 1" to find the last internal revision
landed in Chrome. The descending order will help other folks quickly spot next
CL to merge.

[Fan Yang, 2017-04-27 17:51:39]

Description was changed from

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=
==========

[Fan Yang, 2017-04-27 17:52:35]

Description was changed from

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=
==========

[Fan Yang, 2017-04-27 17:54:10]

On 2017/04/27 17:46:43, Zhongyi Shi wrote:
> Before I start to review your merge CL list, could you update your cl
> description to list the CLs in a descending order? We run "git log
> --pretty=medium net/quic | grep -i -A 100 'Landing Recent QUIC changes' | grep
> -i 'Merge internal change' | head -n 1" to find the last internal revision
> landed in Chrome. The descending order will help other folks quickly spot next
> CL to merge.

Done. Yeah, sorry. I did it in the wrong order.

[Zhongyi Shi, 2017-04-27 20:01:57]

On 2017/04/27 17:54:10, Fan Yang wrote:
> On 2017/04/27 17:46:43, Zhongyi Shi wrote:
> > Before I start to review your merge CL list, could you update your cl
> > description to list the CLs in a descending order? We run "git log
> > --pretty=medium net/quic | grep -i -A 100 'Landing Recent QUIC changes' |
grep
> > -i 'Merge internal change' | head -n 1" to find the last internal revision
> > landed in Chrome. The descending order will help other folks quickly spot
next
> > CL to merge.
> 
> Done. Yeah, sorry. I did it in the wrong order.

No worries. Most of the changes look good to me, you will need to fix the
compile error and address those CLs which I haven't stamped yet. Feel free to
ping me in this CL when it's ready to land.

[Zhongyi Shi, 2017-04-27 20:02:10]

https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
File net/quic/core/quic_data_writer_test.cc (right):

https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
net/quic/core/quic_data_writer_test.cc:466: char big_endian64[] = {0x11, 0x22,
0x33, 0x44, 0x55, 0x66, 0x77, 0x88};
Ah, anything over 0x7f is beyond what char can handle and might be converted to
a negative number. 

You might consider change that to unsigned char?

[Fan Yang, 2017-04-28 13:08:47]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[Fan Yang, 2017-04-28 13:09:06]

On 2017/04/27 20:02:10, Zhongyi Shi wrote:
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> File net/quic/core/quic_data_writer_test.cc (right):
> 
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> net/quic/core/quic_data_writer_test.cc:466: char big_endian64[] = {0x11, 0x22,
> 0x33, 0x44, 0x55, 0x66, 0x77, 0x88};
> Ah, anything over 0x7f is beyond what char can handle and might be converted
to
> a negative number. 
> 
> You might consider change that to unsigned char?

Done, thanks!

[Fan Yang, 2017-04-28 13:09:08]

On 2017/04/27 20:02:10, Zhongyi Shi wrote:
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> File net/quic/core/quic_data_writer_test.cc (right):
> 
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> net/quic/core/quic_data_writer_test.cc:466: char big_endian64[] = {0x11, 0x22,
> 0x33, 0x44, 0x55, 0x66, 0x77, 0x88};
> Ah, anything over 0x7f is beyond what char can handle and might be converted
to
> a negative number. 
> 
> You might consider change that to unsigned char?

Done, thanks!

[commit-bot: I haz the power, 2017-04-28 13:09:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:00:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fan Yang, 2017-04-28 18:03:12]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 18:03:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-04-28 19:03:07]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 19:04:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-04-28 20:07:02]

Patchset #6 (id:100001) has been deleted

[Fan Yang, 2017-04-28 20:08:08]

On 2017/04/28 13:09:08, Fan Yang wrote:
> On 2017/04/27 20:02:10, Zhongyi Shi wrote:
> >
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> > File net/quic/core/quic_data_writer_test.cc (right):
> > 
> >
>
https://codereview.chromium.org/2850573002/diff/20001/net/quic/core/quic_data...
> > net/quic/core/quic_data_writer_test.cc:466: char big_endian64[] = {0x11,
0x22,
> > 0x33, 0x44, 0x55, 0x66, 0x77, 0x88};
> > Ah, anything over 0x7f is beyond what char can handle and might be converted
> to
> > a negative number. 
> > 
> > You might consider change that to unsigned char?
> 
> Done, thanks!

Good to have this sorted out. So I think we can land this set 5.

[commit-bot: I haz the power, 2017-04-28 20:17:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhongyi Shi, 2017-04-28 20:31:23]

Thanks for getting to the bottom of this! 

lgtm

[commit-bot: I haz the power, 2017-04-28 21:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:03:22]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2017-04-28 21:38:03]

The CQ bit was checked by fayang@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:38:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:44:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493415483132740,
"parent_rev": "984c8d18acf4b891d5bf39db6a898e2187340e0f", "commit_rev":
"85d5c4c2d9dde6ba83499588bafb011c45db5792"}

[commit-bot: I haz the power, 2017-04-28 21:44:38]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493415483132740,
"parent_rev": "b60c149b4c9fb340f0eb0b1ec72d67f5ecce9398", "commit_rev":
"127c6abecca77a09866078eb781645ba9aea32d7"}

[commit-bot: I haz the power, 2017-04-28 21:44:51]

Description was changed from

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:35 PM, Apr 26, 2017 UTC-4

Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true.
https://codereview.chromium.org/2849543003/

Rename FLAGS_quic_enable_version_39 to
FLAGS_quic_reloadable_flag_quic_enable_version_39.
Merge internal change: 154330328
https://codereview.chromium.org/2848633003/

Include "base/macros.h" in quic_mutex.h
Merge internal change: 154304557
https://codereview.chromium.org/2841283003/

Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE
frame every 20 packets which do not have retransmittble frames.
Merge internal change: 154290226
https://codereview.chromium.org/2846033002/

In QUIC v39, read and write integers and floating numbers in big endian.
Merge internal change: 154287990
https://codereview.chromium.org/2842373003/

Make QuicSession::OnFinalByteOffsetReceived virtual.
Merge internal change: 154212957
https://codereview.chromium.org/2840423003/

Fix packet conservation logic in QUIC BBR.  Protected by
FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation.
Merge internal change: 154129181
https://codereview.chromium.org/2848633002/

QUIC: correctly update local stream state on receipt of trailers after
sending RST. Protected by
FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers
Rename UpdateFlowControlOnFinalReceivedByteOffset to
OnFinalByteOffsetReceived as it is not limited to updating flow control
(also removes streams from locally_closed_streams_highest_offset).
Merge internal change: 154081704
https://codereview.chromium.org/2850523002/

Delete QUIC/SPDY utility methods for parsing headers/trailers.
Merge internal change: 154068097
https://codereview.chromium.org/2850513002/

Remove unused packet parameter from
QuicTimeWaitListManager::ProcessPacket.
Merge internal change: 153857099
https://codereview.chromium.org/2849543002/

Remove unused packet_number parameter from multiple functions in
QUIC.
Merge internal change: 153847178
https://codereview.chromium.org/2846013002/

Deprecate
FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset.
Merge internal change: 153829126
https://codereview.chromium.org/2846003002/

Some changes to prepare for endian change for QUIC:
1) Make data reader/write be able to read/write integers and floating
numbers in big endian.
2) Make data reader/write be able to read/write 24/40/48/56-bit
integers.
3) Add functions to read/write QuicPacketNumber, QuicStreamId,
QuicStreamOffset in QuicFramer.
Merge internal change: 153820887
https://codereview.chromium.org/2847753002/

Remove std::move from return statements.
Merge internal change: 153819488
https://codereview.chromium.org/2851503002/

BUG=

Review-Url: https://codereview.chromium.org/2850573002
Cr-Commit-Position: refs/heads/master@{#468142}
Committed:
https://chromium.googlesource.com/chromium/src/+/127c6abecca77a09866078eb7816...
==========

[commit-bot: I haz the power, 2017-04-28 21:44:52]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/127c6abecca77a09866078eb7816...