Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2850543002: Fix recipes.py test train when on-disk expectation files are invalid (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix recipes.py test train when on-disk expectation files are invalid BUG=chromium:712828 Review-Url: https://codereview.chromium.org/2850543002 Committed: https://github.com/luci/recipes-py/commit/d84fead2a2eb7e0fe72c928fca0086df619509d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M recipe_engine/test.py View 1 chunk +10 lines, -3 lines 0 comments Download
M unittests/test_test.py View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-04-27 15:30:17 UTC) #6
iannucci
lgtm
3 years, 7 months ago (2017-04-27 15:58:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850543002/1
3 years, 7 months ago (2017-04-27 18:21:05 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 18:24:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/d84fead2a2eb7e0fe72c928fca0086df619...

Powered by Google App Engine
This is Rietveld 408576698