Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2850533002: Store unique_ptr instead of raw poiter in extension callback map (Closed)

Created:
3 years, 7 months ago by apisarev
Modified:
3 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Store unique_ptr instead of raw poiter in extension callback map There is callback map in extension function dispatcher, which store pointers on callback wrappers. But it force to remember to delete wrapper after erase from map. This may lead to memory leak. To prevent it, raw pointer in map was replaced by unique_ptr (like in other callback map in same class). BUG=None R=finnur Review-Url: https://codereview.chromium.org/2850533002 Cr-Commit-Position: refs/heads/master@{#467932} Committed: https://chromium.googlesource.com/chromium/src/+/fbaad662ea5f8e62e03ab2febe39b7cd7946d047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M extensions/browser/extension_function_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
apisarev
3 years, 7 months ago (2017-04-27 14:41:16 UTC) #1
Finnur
LGTM
3 years, 7 months ago (2017-04-27 14:48:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850533002/1
3 years, 7 months ago (2017-04-27 14:52:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/371832)
3 years, 7 months ago (2017-04-27 17:53:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850533002/1
3 years, 7 months ago (2017-04-28 08:09:40 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 08:37:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbaad662ea5f8e62e03ab2febe39...

Powered by Google App Engine
This is Rietveld 408576698