Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2850523002: QUIC: correctly update local stream state on receipt of trailers after sending RST. Protected by FL… (Closed)

Created:
3 years, 7 months ago by Fan Yang
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC: correctly update local stream state on receipt of trailers after sending RST. Protected by FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers Rename UpdateFlowControlOnFinalReceivedByteOffset to OnFinalByteOffsetReceived as it is not limited to updating flow control (also removes streams from locally_closed_streams_highest_offset). Merge internal change: 154081704 R=zhongyi@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -13 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +5 lines, -5 lines 0 comments Download
M net/quic/core/quic_session.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 2 chunks +31 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +77 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
Fan Yang
3 years, 7 months ago (2017-04-27 14:18:41 UTC) #1
Zhongyi Shi
3 years, 7 months ago (2017-04-27 19:18:29 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698