Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2850503006: Android: disables observing changes for font prefs. (Closed)

Created:
3 years, 7 months ago by ssid
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: disables observing changes for font prefs. On Android, there's no exposed way to change font preferences. This will save ~200KB of heap. This change was done in crrev.com/12529014 but was later reverted in crrev.com/444843002 by mistake. So, remove them again. BUG=716195 Review-Url: https://codereview.chromium.org/2850503006 Cr-Commit-Position: refs/heads/master@{#468717} Committed: https://chromium.googlesource.com/chromium/src/+/c517d74afe77cf489a7a59c2b24039df512ae2a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 4 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
ssid
ptal thanks
3 years, 7 months ago (2017-04-28 23:51:46 UTC) #4
Bernhard Bauer
Oops :) LGTM.
3 years, 7 months ago (2017-05-02 09:05:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850503006/1
3 years, 7 months ago (2017-05-02 17:45:24 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:48:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c517d74afe77cf489a7a59c2b240...

Powered by Google App Engine
This is Rietveld 408576698