Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2850503005: Call resolveLibraryMetadata only when dart:mirrors are loaded (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Call resolveLibraryMetadata only when dart:mirrors are loaded This addresses a comment from https://codereview.chromium.org/2846433003 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/057a3fdf4b32ae431407c774431898a941cc2883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-04-28 08:07:50 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-04-28 22:23:32 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-01 12:47:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
057a3fdf4b32ae431407c774431898a941cc2883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698