Run closed_world2_test using the normal compiler pipeline.

Run closed_world2_test using the normal compiler pipeline.

This is a step towards running the front end of the compiler from
'.dill' files.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a4960a150758144930dd87e0716b372948f5ac21

[Johnni Winther, 2017-04-26 12:21:42]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-04-26 12:21:43]

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:567: if (mainFunction == null) return;
This occurs when mainFunction would have been an ErroneousElementX.

[Siggi Cherem (dart-lang), 2017-04-26 16:39:18]

lgtm with a couple small comments

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:700: if (commonElements.mirrorsLibrary ==
null) return;
mmm... is this only used to resolve metadata that is read via mirrors?

I thought we needed this also to validate some of the metadata that we use for
other features, like js-interop. For example, to do the validation with an
annotation processor of a @JS annotation on a library.

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:774: if (compiler.mainApp is!
LibraryElement) return;
to make this easier to read, I'd switch this to:

if (compiler.options.loadDill) return;

[Johnni Winther, 2017-04-27 06:50:14]

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:700: if (commonElements.mirrorsLibrary ==
null) return;
On 2017/04/26 16:39:18, Siggi Cherem (dart-lang) wrote:
> mmm... is this only used to resolve metadata that is read via mirrors?
> 
> I thought we needed this also to validate some of the metadata that we use for
> other features, like js-interop. For example, to do the validation with an
> annotation processor of a @JS annotation on a library.

_ElementAnnotationProcessor.extractJsInteropAnnotations ensures this.

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:774: if (compiler.mainApp is!
LibraryElement) return;
On 2017/04/26 16:39:18, Siggi Cherem (dart-lang) wrote:
> to make this easier to read, I'd switch this to:
> 
> if (compiler.options.loadDill) return; 

Done.

[Johnni Winther, 2017-04-27 06:55:44]

Description was changed from

==========
Run closed_world2_test using the normal compiler pipeline.

This is a step towards running the front end of the compiler from
'.dill' files.
==========

to

==========
Run closed_world2_test using the normal compiler pipeline.

This is a step towards running the front end of the compiler from
'.dill' files.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a4960a150758144930dd87e0716b372948f5ac21
==========

[Johnni Winther, 2017-04-27 06:55:45]

Committed patchset #2 (id:20001) manually as
a4960a150758144930dd87e0716b372948f5ac21 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-04-27 21:11:52]

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:700: if (commonElements.mirrorsLibrary ==
null) return;
On 2017/04/27 06:50:14, Johnni Winther wrote:
> On 2017/04/26 16:39:18, Siggi Cherem (dart-lang) wrote:
> > mmm... is this only used to resolve metadata that is read via mirrors?
> > 
> > I thought we needed this also to validate some of the metadata that we use
for
> > other features, like js-interop. For example, to do the validation with an
> > annotation processor of a @JS annotation on a library.
> 
> _ElementAnnotationProcessor.extractJsInteropAnnotations ensures this.

In that case, maybe change where we call this to only call it for mirrors, so we
can switch this into an assertion instead?

[Johnni Winther, 2017-04-28 08:07:35]

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2846433003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:700: if (commonElements.mirrorsLibrary ==
null) return;
On 2017/04/27 21:11:52, Siggi Cherem (dart-lang) wrote:
> On 2017/04/27 06:50:14, Johnni Winther wrote:
> > On 2017/04/26 16:39:18, Siggi Cherem (dart-lang) wrote:
> > > mmm... is this only used to resolve metadata that is read via mirrors?
> > > 
> > > I thought we needed this also to validate some of the metadata that we use
> for
> > > other features, like js-interop. For example, to do the validation with an
> > > annotation processor of a @JS annotation on a library.
> > 
> > _ElementAnnotationProcessor.extractJsInteropAnnotations ensures this.
> 
> In that case, maybe change where we call this to only call it for mirrors, so
we
> can switch this into an assertion instead?

Done in https://codereview.chromium.org/2850503005