Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2850503002: Enable "interledger" non-URI payment method. (Closed)

Created:
3 years, 7 months ago by please use gerrit instead
Modified:
3 years, 7 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, zkoch+fyi_chromium.org, adrian_ripple.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable "interledger" non-URI payment method. After this patch, Android payment applications can support "interledger" payment method by adding the following section to their AndroidManifest.xml file: <activity android:name=".PaymentActivity" android:exported="true"> <intent-filter> <action android:name="org.chromium.intent.action.PAY" /> </intent-filter> <meta-data android:name="org.chromium.default_payment_method_name" android:value="interledger" /> </activity> Flag: chrome://flags/#android-payment-apps Design: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=715577 Review-Url: https://codereview.chromium.org/2850503002 Cr-Commit-Position: refs/heads/master@{#467689} Committed: https://chromium.googlesource.com/chromium/src/+/499dce94255c5175beeb668c2bdd7a9fc8a6576b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ganggui's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java View 1 6 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
please use gerrit instead
Ganggui, ptal.
3 years, 7 months ago (2017-04-27 14:11:14 UTC) #4
gogerald1
lgtm with a recommendation, https://codereview.chromium.org/2850503002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2850503002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode118 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:118: supportedNonUriPaymentMethods.add(BASIC_CARD_PAYMENT_METHOD); use "basic-card" here as ...
3 years, 7 months ago (2017-04-27 14:35:33 UTC) #5
please use gerrit instead
Sending to cq. https://codereview.chromium.org/2850503002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java (right): https://codereview.chromium.org/2850503002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java#newcode118 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java:118: supportedNonUriPaymentMethods.add(BASIC_CARD_PAYMENT_METHOD); On 2017/04/27 14:35:33, gogerald1 wrote: ...
3 years, 7 months ago (2017-04-27 14:41:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850503002/20001
3 years, 7 months ago (2017-04-27 14:41:56 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:39:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/499dce94255c5175beeb668c2bdd...

Powered by Google App Engine
This is Rietveld 408576698