Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2850453002: Adding OWNERS to various ios directories. (Closed)

Created:
3 years, 7 months ago by jif
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding OWNERS to various ios directories. BUG=None Review-Url: https://codereview.chromium.org/2850453002 Cr-Commit-Position: refs/heads/master@{#467933} Committed: https://chromium.googlesource.com/chromium/src/+/f32671c0f445b58612ebba5c7a72de7c7981e8e9

Patch Set 1 #

Total comments: 2

Patch Set 2 : rohit owner of ios/c/b/find_in_page. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A + ios/chrome/browser/find_in_page/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A ios/chrome/browser/history/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/store_kit/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/find_bar/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A ios/chrome/browser/ui/keyboard/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/web_state_list/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
jif
Reviewers, PTAL at the files where your names are.
3 years, 7 months ago (2017-04-27 11:37:48 UTC) #6
sdefresne
lgtm for ios/chrome/browser/web_state_list
3 years, 7 months ago (2017-04-27 12:30:51 UTC) #7
rohitrao (ping after 24h)
lgtm when the new OWNERS sign off on this Thanks! https://codereview.chromium.org/2850453002/diff/20001/ios/chrome/browser/find_in_page/OWNERS File ios/chrome/browser/find_in_page/OWNERS (left): https://codereview.chromium.org/2850453002/diff/20001/ios/chrome/browser/find_in_page/OWNERS#oldcode2 ...
3 years, 7 months ago (2017-04-27 12:48:52 UTC) #8
lpromero
lgtm
3 years, 7 months ago (2017-04-27 14:49:39 UTC) #9
sczs
lgtm Since I've been refactoring ToolsMenu, I'd feel comfortable being an OWNER on there as ...
3 years, 7 months ago (2017-04-27 14:54:28 UTC) #10
justincohen
LGTM
3 years, 7 months ago (2017-04-27 14:57:53 UTC) #11
stkhapugin
lgtm https://codereview.chromium.org/2850453002/diff/20001/ios/chrome/browser/find_in_page/OWNERS File ios/chrome/browser/find_in_page/OWNERS (left): https://codereview.chromium.org/2850453002/diff/20001/ios/chrome/browser/find_in_page/OWNERS#oldcode2 ios/chrome/browser/find_in_page/OWNERS:2: rohitrao@chromium.org On 2017/04/27 12:48:52, rohitrao (ping after 24h) ...
3 years, 7 months ago (2017-04-28 08:24:54 UTC) #12
jif
Addressed comments. thank you all!
3 years, 7 months ago (2017-04-28 08:31:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850453002/60001
3 years, 7 months ago (2017-04-28 08:31:09 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 08:40:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f32671c0f445b58612ebba5c7a72...

Powered by Google App Engine
This is Rietveld 408576698