Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2850443004: Show "with <something>" for federated credentials in the MD settings. (Closed)

Created:
3 years, 7 months ago by vasilii
Modified:
3 years, 7 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Show "with <something>" for federated credentials in the MD settings. A screenshot is attached to the bug. BUG=706310 TBR=hcarmona@chromium.org Review-Url: https://codereview.chromium.org/2805683002 Cr-Commit-Position: refs/heads/master@{#466400} (cherry picked from commit 7a0ea2253643c495276d4f5953871318f706509a) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2850443004 . Cr-Commit-Position: refs/branch-heads/3071@{#262} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/97528cb013f79356e813919e35c4c2d9509d69f2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
vasilii
3 years, 7 months ago (2017-04-27 14:22:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
97528cb013f79356e813919e35c4c2d9509d69f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698