Add OWNERS to layout tests owned by device-dev team.

Add OWNERS to layout tests owned by device-dev team.

R=dougt@chromium.org, reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2850363002 .
Cr-Commit-Position: refs/heads/master@{#468737}
Committed: https://chromium.googlesource.com/chromium/src/+/25a65028b3fd10ffe5850daf25187e4d5d930a66

[scheib, 2017-05-02 04:17:43]

scheib@chromium.org changed reviewers:
+ dougt@chromium.org

[scheib, 2017-05-02 04:18:46]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 04:18:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-05-02 04:22:11]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2017-05-02 04:22:12]

I was going to mention adding OWNERS to web platform tests e.g.[1] but upon
further inspection I see we only have gamepad web-platform tests D:

[1]
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...

[scheib, 2017-05-02 04:35:17]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 04:35:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2017-05-02 04:36:51]

On 2017/05/02 04:22:12, ortuno wrote:
> I was going to mention adding OWNERS to web platform tests e.g.[1] but upon
> further inspection I see we only have gamepad web-platform tests D:
> 
> [1]
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...

Nice catch, I found 4 wpt subdirs.

[dougt, 2017-05-02 04:52:41]

lgtm. really <3 team ownership.

[commit-bot: I haz the power, 2017-05-02 05:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 05:56:02]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-05-02 15:37:43]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-05-02 15:37:44]

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2: reillyg@chromium.org
Why are you removing the existing OWNERS?

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/geolocation-api/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/geolocation-api/OWNERS:1: mcasas@chromium.org
Here too.

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/imagecapture/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/OWNERS:1: mcasas@chromium.org
And here.

[dougt, 2017-05-02 15:51:15]

There is an argument to be made that teams not singleton people should own
areas of code. But I think this best be discussed on one of the mailing
list?

On Tue, May 2, 2017 at 8:37 AM, <reillyg@chromium.org> wrote:

>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/fast/imagecapture/OWNERS
> File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/fast/imagecapture/OWNERS#oldcode2
> third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2:
> reillyg@chromium.org
> Why are you removing the existing OWNERS?
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/geolocation-api/OWNERS
> File third_party/WebKit/LayoutTests/geolocation-api/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/geolocation-api/OWNERS#oldcode1
> third_party/WebKit/LayoutTests/geolocation-api/OWNERS:1:
> mcasas@chromium.org
> Here too.
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/imagecapture/OWNERS
> File third_party/WebKit/LayoutTests/imagecapture/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/imagecapture/OWNERS#oldcode1
> third_party/WebKit/LayoutTests/imagecapture/OWNERS:1:
> mcasas@chromium.org
> And here.
>
> https://codereview.chromium.org/2850363002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dougt, 2017-05-02 15:51:16]

There is an argument to be made that teams not singleton people should own
areas of code. But I think this best be discussed on one of the mailing
list?

On Tue, May 2, 2017 at 8:37 AM, <reillyg@chromium.org> wrote:

>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/fast/imagecapture/OWNERS
> File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/fast/imagecapture/OWNERS#oldcode2
> third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2:
> reillyg@chromium.org
> Why are you removing the existing OWNERS?
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/geolocation-api/OWNERS
> File third_party/WebKit/LayoutTests/geolocation-api/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/geolocation-api/OWNERS#oldcode1
> third_party/WebKit/LayoutTests/geolocation-api/OWNERS:1:
> mcasas@chromium.org
> Here too.
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/imagecapture/OWNERS
> File third_party/WebKit/LayoutTests/imagecapture/OWNERS (left):
>
> https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/
> LayoutTests/imagecapture/OWNERS#oldcode1
> third_party/WebKit/LayoutTests/imagecapture/OWNERS:1:
> mcasas@chromium.org
> And here.
>
> https://codereview.chromium.org/2850363002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Reilly Grant (use Gerrit), 2017-05-02 16:02:01]

On 2017/05/02 15:51:16, dougt wrote:
> There is an argument to be made that teams not singleton people should own
> areas of code. But I think this best be discussed on one of the mailing
> list?

The problem is that our tooling doesn't understand TEAMs and membership in
device-dev@ doesn't imply ownership of the code.

[scheib, 2017-05-02 16:43:33]

On 2017/05/02 16:02:01, Reilly Grant wrote:
> On 2017/05/02 15:51:16, dougt wrote:
> > There is an argument to be made that teams not singleton people should own
> > areas of code. But I think this best be discussed on one of the mailing
> > list?
> 
> The problem is that our tooling doesn't understand TEAMs and membership in
> device-dev@ doesn't imply ownership of the code.

This patch is to support triage tooling, which uses TEAM and COMPONENT fields in
OWNERS files.

This doesn't solve code review approval, but LayoutTests already have * for
OWNERS.

Elsewhere, if we do want to list 'team as OWNERS' we can use
file://some-path/DEVICE_OWNERS. I'm unsure we want to do this yet.

[scheib, 2017-05-02 16:46:29]

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2: reillyg@chromium.org
On 2017/05/02 15:37:44, Reilly Grant wrote:
> Why are you removing the existing OWNERS?

These are new OWNERS files. git diff did a similarity match and is showing
another source file as OLD and confusing that point. The only file that already
existed was third_party/WebKit/LayoutTests/usb/OWNERS.

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/geolocation-api/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/geolocation-api/OWNERS:1: mcasas@chromium.org
On 2017/05/02 15:37:44, Reilly Grant wrote:
> Here too.

ditto

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/imagecapture/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imagecapture/OWNERS:1: mcasas@chromium.org
On 2017/05/02 15:37:44, Reilly Grant wrote:
> And here.

ditto

[Reilly Grant (use Gerrit), 2017-05-02 17:04:51]

lgtm

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):

https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2: reillyg@chromium.org
On 2017/05/02 16:46:28, scheib wrote:
> On 2017/05/02 15:37:44, Reilly Grant wrote:
> > Why are you removing the existing OWNERS?
> 
> These are new OWNERS files. git diff did a similarity match and is showing
> another source file as OLD and confusing that point. The only file that
already
> existed was third_party/WebKit/LayoutTests/usb/OWNERS.

Acknowledged.

[mcasas, 2017-05-02 17:13:26]

On 2017/05/02 17:04:51, Reilly Grant wrote:
> lgtm
> 
>
https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS (left):
> 
>
https://codereview.chromium.org/2850363002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS:2:
mailto:reillyg@chromium.org
> On 2017/05/02 16:46:28, scheib wrote:
> > On 2017/05/02 15:37:44, Reilly Grant wrote:
> > > Why are you removing the existing OWNERS?
> > 
> > These are new OWNERS files. git diff did a similarity match and is showing
> > another source file as OLD and confusing that point. The only file that
> already
> > existed was third_party/WebKit/LayoutTests/usb/OWNERS.
> 
> Acknowledged.

You could try and git cl upload --similarity=90 to eliminate those
false positives, but probably is not worth it.

[scheib, 2017-05-02 17:19:50]

Patchset #3 (id:40001) has been deleted

[scheib, 2017-05-02 17:20:04]

The CQ bit was checked by scheib@chromium.org

[scheib, 2017-05-02 17:20:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dougt@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2850363002/#ps60001
(title: "fix similarity to not show incorrect old file sources")

[commit-bot: I haz the power, 2017-05-02 17:20:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:29:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scheib, 2017-05-02 19:23:24]

On 2017/05/02 17:29:10, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

https://storage.googleapis.com/chromium-owners/component_map.json is stale, and
hasn't picked up changes from https://codereview.chromium.org/2854763003#ps1
yet.

[scheib, 2017-05-02 19:25:42]

Description was changed from

==========
Add OWNERS to layout tests owned by device-dev team.
==========

to

==========
Add OWNERS to layout tests owned by device-dev team.

R=dougt@chromium.org, reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2850363002 .
Cr-Commit-Position: refs/heads/master@{#468737}
Committed:
https://chromium.googlesource.com/chromium/src/+/25a65028b3fd10ffe5850daf2518...
==========

[scheib, 2017-05-02 19:25:44]

Committed patchset #3 (id:60001) manually as
25a65028b3fd10ffe5850daf25187e4d5d930a66.