Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 2850353002: Reduce the log level for printer capability fetch failure. (Closed)

Created:
3 years, 7 months ago by skau
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, rbpotter
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the log level for printer capability fetch failure. If printer capability fetch fails, it is indicative of an error, but it is recoverable. So, it should be reduced to a warning. This enables testing of the failure case for printer capability retrieval. BUG=708834 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2850353002 Cr-Commit-Position: refs/heads/master@{#468850} Committed: https://chromium.googlesource.com/chromium/src/+/d3b61aeab646c01a5e0a921a580e603f160678e3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/print_preview_destination_search_test.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
skau
dpapad@ Please take a look. This is a follow-on to the other printer test fixes.
3 years, 7 months ago (2017-05-02 02:01:42 UTC) #3
dpapad
lgtm
3 years, 7 months ago (2017-05-02 18:54:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850353002/20001
3 years, 7 months ago (2017-05-02 23:40:33 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:08:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d3b61aeab646c01a5e0a921a580e...

Powered by Google App Engine
This is Rietveld 408576698