DevTools: Promisify Profiler and HeapProfiler domains

third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

Index: third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
index 99849477b28d17a5efb0a40473b882d00a39873c..7e5b0d97eede06a59886aaf305a375fd2df79aa0 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
@@ -41,11 +41,11 @@ SDK.HeapProfilerModel = class extends SDK.SDKModel {
   }
 
   /**
-   * @return {!Promise.<?Protocol.HeapProfiler.SamplingHeapProfile>}
+   * @return {!Promise<?Protocol.HeapProfiler.SamplingHeapProfile>}
    */
   stopSampling() {
     this._isRecording = false;
-    return this._heapProfilerAgent.stopSampling((error, profile) => error ? null : profile);
+    return this._heapProfilerAgent.stopSampling();
   }
 
   /**
@@ -60,7 +60,7 @@ SDK.HeapProfilerModel = class extends SDK.SDKModel {
    * @return {!Promise<?string>}
    */
   snapshotObjectIdForObjectId(objectId) {
-    return this._heapProfilerAgent.getHeapObjectId(objectId, (error, result) => error ? null : result);
+    return this._heapProfilerAgent.getHeapObjectId(objectId);
   }
 
   /**
@@ -69,11 +69,8 @@ SDK.HeapProfilerModel = class extends SDK.SDKModel {
    * @return {!Promise<?SDK.RemoteObject>}
    */
   objectForSnapshotObjectId(snapshotObjectId, objectGroupName) {
-    return this._heapProfilerAgent.getObjectByHeapObjectId(snapshotObjectId, objectGroupName, (error, result) => {
-      if (error || !result.type)
-        return null;
-      return this._runtimeModel.createRemoteObject(result);
-    });
+    return this._heapProfilerAgent.getObjectByHeapObjectId(snapshotObjectId, objectGroupName)
+        .then(result => result && result.type ? this._runtimeModel.createRemoteObject(result) : null);
   }
 
   /**
@@ -89,7 +86,8 @@ SDK.HeapProfilerModel = class extends SDK.SDKModel {
    * @return {!Promise<boolean>}
    */
   takeHeapSnapshot(reportProgress) {
-    return this._heapProfilerAgent.takeHeapSnapshot(reportProgress, error => !error);
+    return this._heapProfilerAgent.invoke_takeHeapSnapshot({reportProgress: reportProgress})

[dgozman, 2017/05/02 20:03:41]

Can we do something here? Do you have an idea how many methods need this
boolean? Maybe even these ones don't?

[alph, 2017/05/02 22:48:06]

Done.

+        .then(response => !response[Protocol.Error]);
   }
 
   /**
@@ -105,11 +103,12 @@ SDK.HeapProfilerModel = class extends SDK.SDKModel {
    * @return {!Promise<boolean>}
    */
   stopTrackingHeapObjects(reportProgress) {
-    return this._heapProfilerAgent.stopTrackingHeapObjects(reportProgress, error => !error);
+    return this._heapProfilerAgent.invoke_stopTrackingHeapObjects({reportProgress: reportProgress})
+        .then(response => !response[Protocol.Error]);
   }
 
   /**
-   * @param {!Array.<number>} samples
+   * @param {!Array<number>} samples
    */
   heapStatsUpdate(samples) {
     this.dispatchEventToListeners(SDK.HeapProfilerModel.Events.HeapStatsUpdate, samples);