third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js - Issue 2850333002: DevTools: Promisify Profiler and HeapProfiler domains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

Issue 2850333002: DevTools: Promisify Profiler and HeapProfiler domains (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

diff --git a/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js b/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

index 8dffb4581a19902f968543fd6458e0e65f608e80..92c156063fc7424072ce49ad10caa27e6078f880 100644

--- a/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

+++ b/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js

@@ -628,9 +628,10 @@ Protocol.InspectorBackend._AgentPrototype = class {

/**

* @param {!Array<*>} args

+ * @return {?}

function runUserCallback(args) {

- return userCallback ? userCallback.apply(null, args) : undefined;

+ return userCallback ? userCallback.apply(null, args) : args[1] || null;

dgozman 2017/05/02 20:03:41 Everyone was checking for error, not for null/unde

alph 2017/05/02 22:48:06 Done.

}