ErrorPage: use case-insensitive check for text

ErrorPage: use case-insensitive check for text

No change to production logic.

This CL uses a case-insensitive check to see if text is included in the
document body.

The mobile layout fully capitalizes buttons, while the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG=717254
Review-Url: https://codereview.chromium.org/2850293002
Cr-Commit-Position: refs/heads/master@{#468667}
Committed: https://chromium.googlesource.com/chromium/src/+/1d82d39ab1671da7e27edb1e433eb413f1a4576a

[Nate Fischer, 2017-05-01 21:52:22]

The CQ bit was checked by ntfschr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 21:53:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Fischer, 2017-05-01 21:56:37]

ntfschr@chromium.org changed reviewers:
+ mmenke@chromium.org

[Nate Fischer, 2017-05-01 21:58:03]

Description was changed from

==========
ErrorPage: use case-insensitive check for text

No change to production logic.

Use a case-insensitive check to see if text is included in the document
body. The mobile layout fully capitalizes buttons, whereas the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG=717254
==========

to

==========
ErrorPage: use case-insensitive check for text

No change to production logic.

This CL uses a case-insensitive check to see if text is included in the
document body.

The mobile layout fully capitalizes buttons, while the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG=717254
==========

[Nate Fischer, 2017-05-01 22:30:12]

PTAL.

This blocks http://crrev/2848733002, since that CL will cause more of the tests
to run against the mobile layout.

[commit-bot: I haz the power, 2017-05-01 22:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:50:38]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-05-02 15:31:26]

On 2017/05/01 22:30:12, Nate Fischer wrote:
> PTAL.
> 
> This blocks http://crrev/2848733002, since that CL will cause more of the
tests
> to run against the mobile layout.

LGTM.

[Nate Fischer, 2017-05-02 16:13:59]

On 2017/05/02 15:31:26, mmenke wrote:
> On 2017/05/01 22:30:12, Nate Fischer wrote:
> > PTAL.
> > 
> > This blocks http://crrev/2848733002, since that CL will cause more of the
> tests
> > to run against the mobile layout.
> 
> LGTM.

Thanks, Matt!

[Nate Fischer, 2017-05-02 16:14:05]

The CQ bit was checked by ntfschr@chromium.org

[commit-bot: I haz the power, 2017-05-02 16:14:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:19:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493741645681870, "parent_rev":
"adec59cbccb4b0ff02d501ffac56bc4d73fc2d38", "commit_rev":
"1d82d39ab1671da7e27edb1e433eb413f1a4576a"}

[commit-bot: I haz the power, 2017-05-02 16:20:08]

Description was changed from

==========
ErrorPage: use case-insensitive check for text

No change to production logic.

This CL uses a case-insensitive check to see if text is included in the
document body.

The mobile layout fully capitalizes buttons, while the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG=717254
==========

to

==========
ErrorPage: use case-insensitive check for text

No change to production logic.

This CL uses a case-insensitive check to see if text is included in the
document body.

The mobile layout fully capitalizes buttons, while the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG=717254

Review-Url: https://codereview.chromium.org/2850293002
Cr-Commit-Position: refs/heads/master@{#468667}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d82d39ab1671da7e27edb1e433e...
==========

[commit-bot: I haz the power, 2017-05-02 16:20:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d82d39ab1671da7e27edb1e433e...