Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2850233002:
Restore tests for single-sample storage in histograms. (Closed)
|
Created:
3 years, 7 months ago by bcwhite Modified:
3 years, 7 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRestore tests for single-sample storage in histograms.
These tests were removed from the main CL because they were
believed to be the cause of some instability in other tests.
Without the tests, everything seems fine so now it's time to
restore these.
Main CL: https://codereview.chromium.org/2811713003/
BUG=705342
Review-Url: https://codereview.chromium.org/2850233002
Cr-Original-Commit-Position: refs/heads/master@{#468396}
Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358b7f335ac0fdc
Review-Url: https://codereview.chromium.org/2850233002
Cr-Commit-Position: refs/heads/master@{#469996}
Committed: https://chromium.googlesource.com/chromium/src/+/0ddc891f2d023a185db9c5a3c4f52bd728e117ed
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : Iterator Get() now returns int64_t 'max' value. #Messages
Total messages: 26 (18 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. BUG=705342 ========== to ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 ==========
bcwhite@chromium.org changed reviewers: + asvitkine@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493668039340880, "parent_rev":
"ba7a53053a967f5ee4b100a7463acebaa52a96ce", "commit_rev":
"da4b99838d459396d412bc278358b7f335ac0fdc"}
Message was sent while issue was closed.
Description was changed from ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 ========== to ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 Review-Url: https://codereview.chromium.org/2850233002 Cr-Commit-Position: refs/heads/master@{#468396} Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2851363002/ by sky@chromium.org. The reason for reverting is: The mac dbg builder has started failing again. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_T... : [ RUN ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug [WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads. ../../base/threading/non_thread_safe_unittest.cc:140: Failure Death test: { NonThreadSafeClass::DestructorOnDifferentThreadImpl(); } Result: died but not with expected error. Expected: Check failed Actual msg: [ DEATH ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec(). [ DEATH ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug. [ DEATH ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec(). [ DEATH ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug. [ DEATH ] Received signal 11 SEGV_MAPERR 000000000110 [ DEATH ] [0x00010bd9c12e] [ DEATH ] [0x00010bd9c1cd] [ DEATH ] [0x00010bd9a65c] [ DEATH ] [0x00010bd9c017] [ DEATH ] [0x7fff915c85aa] [ DEATH ] [0x000000000000] [ DEATH ] [0x7fff95a203f9] [ DEATH ] [0x7fff95a2001b] [ DEATH ] [0x7fff95a1fbed] [ DEATH ] [0x7fff957349cb] [ DEATH ] [0x7fff90a97899] [ DEATH ] [0x7fff90a9772a] [ DEATH ] [0x7fff90a9bfc9] [ DEATH ] [end of stack trace] [ DEATH ] [ FAILED ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug (533 ms) From looking at 705342 it seems as though your changes failed with a similar error before and were reverted. Specifically NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug . I'm going to revert and see if it fixes things..
Message was sent while issue was closed.
Description was changed from ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 Review-Url: https://codereview.chromium.org/2850233002 Cr-Commit-Position: refs/heads/master@{#468396} Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358... ========== to ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 Review-Url: https://codereview.chromium.org/2850233002 Cr-Commit-Position: refs/heads/master@{#468396} Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358... ==========
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://bugs.chromium.org/p/chromium/issues/detail?id=717490 is fixed so this should be safe to submit again.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2850233002/#ps40001 (title: "Iterator Get() now returns int64_t 'max' value.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494258974936640,
"parent_rev": "f18f120c6b5ebef92bd05d50dd60935185daced9", "commit_rev":
"0ddc891f2d023a185db9c5a3c4f52bd728e117ed"}
Message was sent while issue was closed.
Description was changed from ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 Review-Url: https://codereview.chromium.org/2850233002 Cr-Commit-Position: refs/heads/master@{#468396} Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358... ========== to ========== Restore tests for single-sample storage in histograms. These tests were removed from the main CL because they were believed to be the cause of some instability in other tests. Without the tests, everything seems fine so now it's time to restore these. Main CL: https://codereview.chromium.org/2811713003/ BUG=705342 Review-Url: https://codereview.chromium.org/2850233002 Cr-Original-Commit-Position: refs/heads/master@{#468396} Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358... Review-Url: https://codereview.chromium.org/2850233002 Cr-Commit-Position: refs/heads/master@{#469996} Committed: https://chromium.googlesource.com/chromium/src/+/0ddc891f2d023a185db9c5a3c4f5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0ddc891f2d023a185db9c5a3c4f5... |
