Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: components/sync/engine_impl/get_updates_processor.h

Issue 2850213002: [Sync] Minor refactor around SyncCycle and ModelTypeSet usage. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/get_updates_processor.h
diff --git a/components/sync/engine_impl/get_updates_processor.h b/components/sync/engine_impl/get_updates_processor.h
index ad834f4d3f7ade035789a2671599994836bd23e7..01fc2a02552f3cfddde6497f966ccaeca9c478d7 100644
--- a/components/sync/engine_impl/get_updates_processor.h
+++ b/components/sync/engine_impl/get_updates_processor.h
@@ -48,11 +48,12 @@ class GetUpdatesProcessor {
bool create_mobile_bookmarks_folder);
// Applies any downloaded and processed updates.
- void ApplyUpdates(ModelTypeSet gu_types, StatusController* status_controller);
+ void ApplyUpdates(const ModelTypeSet& gu_types,
+ StatusController* status_controller);
private:
// Populates a GetUpdates request message with per-type information.
- void PrepareGetUpdates(ModelTypeSet gu_types,
+ void PrepareGetUpdates(const ModelTypeSet& gu_types,
sync_pb::ClientToServerMessage* message);
// Sends the specified message to the server and stores the response in a
@@ -64,12 +65,12 @@ class GetUpdatesProcessor {
// Helper function for processing responses from the server. Defined here for
// testing.
SyncerError ProcessResponse(const sync_pb::GetUpdatesResponse& gu_response,
- ModelTypeSet proto_request_types,
+ const ModelTypeSet& proto_request_types,
StatusController* status);
// Processes a GetUpdates responses for each type.
SyncerError ProcessGetUpdatesResponse(
- ModelTypeSet gu_types,
+ const ModelTypeSet& gu_types,
const sync_pb::GetUpdatesResponse& gu_response,
StatusController* status_controller);

Powered by Google App Engine
This is Rietveld 408576698