Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9369)

Unified Diff: components/sync/engine_impl/get_updates_delegate.cc

Issue 2850213002: [Sync] Minor refactor around SyncCycle and ModelTypeSet usage. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/get_updates_delegate.cc
diff --git a/components/sync/engine_impl/get_updates_delegate.cc b/components/sync/engine_impl/get_updates_delegate.cc
index 3af3285b7dab6e2036dd6d655569ff69417b4aa5..2e54b54176f9f09a1b749a188024dc3d999d7fd1 100644
--- a/components/sync/engine_impl/get_updates_delegate.cc
+++ b/components/sync/engine_impl/get_updates_delegate.cc
@@ -14,7 +14,7 @@ namespace syncer {
namespace {
-void NonPassiveApplyUpdates(ModelTypeSet gu_types,
+void NonPassiveApplyUpdates(const ModelTypeSet& gu_types,
StatusController* status_controller,
UpdateHandlerMap* update_handler_map) {
for (const auto& kv : *update_handler_map) {
@@ -24,7 +24,7 @@ void NonPassiveApplyUpdates(ModelTypeSet gu_types,
}
}
-void PassiveApplyUpdates(ModelTypeSet gu_types,
+void PassiveApplyUpdates(const ModelTypeSet& gu_types,
StatusController* status_controller,
UpdateHandlerMap* update_handler_map) {
for (const auto& kv : *update_handler_map) {
@@ -79,7 +79,7 @@ void NormalGetUpdatesDelegate::HelpPopulateGuMessage(
}
void NormalGetUpdatesDelegate::ApplyUpdates(
- ModelTypeSet gu_types,
+ const ModelTypeSet& gu_types,
StatusController* status_controller,
UpdateHandlerMap* update_handler_map) const {
NonPassiveApplyUpdates(gu_types, status_controller, update_handler_map);
@@ -105,7 +105,7 @@ void ConfigureGetUpdatesDelegate::HelpPopulateGuMessage(
}
void ConfigureGetUpdatesDelegate::ApplyUpdates(
- ModelTypeSet gu_types,
+ const ModelTypeSet& gu_types,
StatusController* status_controller,
UpdateHandlerMap* update_handler_map) const {
PassiveApplyUpdates(gu_types, status_controller, update_handler_map);
@@ -155,7 +155,7 @@ void PollGetUpdatesDelegate::HelpPopulateGuMessage(
}
void PollGetUpdatesDelegate::ApplyUpdates(
- ModelTypeSet gu_types,
+ const ModelTypeSet& gu_types,
StatusController* status_controller,
UpdateHandlerMap* update_handler_map) const {
NonPassiveApplyUpdates(gu_types, status_controller, update_handler_map);

Powered by Google App Engine
This is Rietveld 408576698