[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=

Review-Url: https://codereview.chromium.org/2850213002
Cr-Commit-Position: refs/heads/master@{#468445}
Committed: https://chromium.googlesource.com/chromium/src/+/81b9933d11a09a3c7cfc1b6c1e3d29f6b4868e10

[skym, 2017-05-01 17:30:21]

Description was changed from

==========
[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

BUG=
==========

to

==========
[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=
==========

[skym, 2017-05-01 17:30:26]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-05-01 17:30:48]

skym@chromium.org changed reviewers:
+ pnoland@chromium.org

[skym, 2017-05-01 17:30:49]

PTAL

[commit-bot: I haz the power, 2017-05-01 17:30:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2017-05-01 18:08:13]

lgtm

https://codereview.chromium.org/2850213002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/get_updates_delegate.h (right):

https://codereview.chromium.org/2850213002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/get_updates_delegate.h:30: // Populates GetUpdate
message fields that depends on GetUpdates request type.
[nit] "depend on"

[commit-bot: I haz the power, 2017-05-01 18:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 18:30:49]

Dry run: This issue passed the CQ dry run.

[skym, 2017-05-01 20:52:36]

https://codereview.chromium.org/2850213002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/get_updates_delegate.h (right):

https://codereview.chromium.org/2850213002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/get_updates_delegate.h:30: // Populates GetUpdate
message fields that depends on GetUpdates request type.
On 2017/05/01 18:08:13, Patrick Noland wrote:
> [nit] "depend on"

Done.

[skym, 2017-05-01 20:52:48]

The CQ bit was checked by skym@chromium.org

[skym, 2017-05-01 20:52:48]

The patchset sent to the CQ was uploaded after l-g-t-m from pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2850213002/#ps20001
(title: "Fix comment grammar.")

[commit-bot: I haz the power, 2017-05-01 20:53:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 22:10:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493671968015140,
"parent_rev": "43d8b52c651ff0086468f5c89235bac5f14cda0d", "commit_rev":
"81b9933d11a09a3c7cfc1b6c1e3d29f6b4868e10"}

[commit-bot: I haz the power, 2017-05-01 22:10:35]

Description was changed from

==========
[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=
==========

to

==========
[Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=

Review-Url: https://codereview.chromium.org/2850213002
Cr-Commit-Position: refs/heads/master@{#468445}
Committed:
https://chromium.googlesource.com/chromium/src/+/81b9933d11a09a3c7cfc1b6c1e3d...
==========

[commit-bot: I haz the power, 2017-05-01 22:10:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81b9933d11a09a3c7cfc1b6c1e3d...