Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2850193002: Timeline: fix frame offsets in Timeline details (Closed)

Created:
3 years, 7 months ago by caseq
Modified:
3 years, 7 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix frame offsets in Timeline details Review-Url: https://codereview.chromium.org/2850193002 Cr-Commit-Position: refs/heads/master@{#468391} Committed: https://chromium.googlesource.com/chromium/src/+/55acd7941b4a69f5271c586c411056cda5163b7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model-expected.txt View 28 chunks +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
caseq
3 years, 7 months ago (2017-05-01 17:36:58 UTC) #2
alph
lgtm
3 years, 7 months ago (2017-05-01 18:17:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850193002/1
3 years, 7 months ago (2017-05-01 18:18:16 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 19:51:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55acd7941b4a69f5271c586c4110...

Powered by Google App Engine
This is Rietveld 408576698