Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2850183003: Re-enable flaky WebVR test (Closed)

Created:
3 years, 7 months ago by bsheedy
Modified:
3 years, 7 months ago
Reviewers:
Miguel Garcia
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable flaky WebVR test Re-enables WebVrTest#testScreenTapsRegisteredOnCardboard, which was flaky on L devices. Was unable to reproduce on devices that it had previously failed on, so re-enabled on all devices at sgurun@'s suggestion. If flakiness occurs again, will disable test on L devices. BUG=713781 Review-Url: https://codereview.chromium.org/2850183003 Cr-Commit-Position: refs/heads/master@{#468792} Committed: https://chromium.googlesource.com/chromium/src/+/cce1f4f3b02e3a65efb572ffdc292724a7ca50b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsheedy
+miguelg@ for chrome/android/javatests OWNERS
3 years, 7 months ago (2017-05-01 22:36:54 UTC) #2
Miguel Garcia
lgtm
3 years, 7 months ago (2017-05-02 21:57:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850183003/1
3 years, 7 months ago (2017-05-02 21:58:32 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 22:23:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cce1f4f3b02e3a65efb572ffdc29...

Powered by Google App Engine
This is Rietveld 408576698