Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2850183002: Fix harness error in payment-request-interface.html layout test. (Closed)

Created:
3 years, 7 months ago by please use gerrit instead
Modified:
3 years, 7 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, blink-reviews, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix harness error in payment-request-interface.html layout test. BUG=705252 Review-Url: https://codereview.chromium.org/2850183002 Cr-Commit-Position: refs/heads/master@{#468363} Committed: https://chromium.googlesource.com/chromium/src/+/b24d35ae72703093d610e86b149d7f21010381ea

Patch Set 1 #

Patch Set 2 : Expecations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -95 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/payments/payment-request-interface-expected.txt View 1 3 chunks +77 lines, -78 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
please use gerrit instead
Mathieu, ptal.
3 years, 7 months ago (2017-05-01 16:54:15 UTC) #4
Mathieu
lgtm Could this move to external/payment-request or it's too tied to our framework?
3 years, 7 months ago (2017-05-01 17:06:57 UTC) #5
please use gerrit instead
On 2017/05/01 17:06:57, Mathieu wrote: > lgtm > > Could this move to external/payment-request or ...
3 years, 7 months ago (2017-05-01 17:13:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850183002/20001
3 years, 7 months ago (2017-05-01 17:13:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:35:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b24d35ae72703093d610e86b149d...

Powered by Google App Engine
This is Rietveld 408576698