Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2850173003: Move LengthSizes border-*-radius out of BorderData (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index f6e17563ed8abefe17f8132ed0a6433b4b2c671c..7814135f0c39750e6224d4884a9293613720d34e 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -1956,7 +1956,15 @@ bool StyleResolver::HasAuthorBackground(const StyleResolverState& state) {
bool StyleResolver::HasAuthorBorder(const StyleResolverState& state) {
const CachedUAStyle* cached_ua_style = state.GetCachedUAStyle();
return cached_ua_style &&
- (cached_ua_style->border != state.Style()->Border());
+ (cached_ua_style->border != state.Style()->Border() &&
+ !(cached_ua_style->top_left_ ==
shend 2017/05/02 00:01:45 Hmm, should this be !(top_left == TopLeft && top_r
nainar 2017/05/02 00:42:33 The != operator doesnt exist could make one but ..
nainar 2017/05/02 00:49:52 wait you were right. Done.
+ state.Style()->BorderTopLeftRadius() ||
+ cached_ua_style->top_right_ ==
+ state.Style()->BorderTopRightRadius() ||
+ cached_ua_style->bottom_left_ ==
+ state.Style()->BorderBottomLeftRadius() ||
+ cached_ua_style->bottom_right_ ==
+ state.Style()->BorderBottomRightRadius()));
}
void StyleResolver::ApplyCallbackSelectors(StyleResolverState& state) {
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698