Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2850153003: Revert of CrOS: Fix appearance of notification toasts when sliding out via gesture (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
yoshiki, Evan Stade
CC:
chromium-reviews, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CrOS: Fix appearance of notification toasts when sliding out via gesture (patchset #4 id:60001 of https://codereview.chromium.org/2849523005/ ) Reason for revert: This appears to have broken message_center_unittests on chromium.win/Win10 Tests x64. See https://uberchromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/11112/steps/message_center_unittests%20on%20Windows-10-10586 for one example. Original issue's description: > CrOS: Fix appearance of notification toasts when sliding out via gesture > > This converts SlideOutView to SlideOutController, which provides all the > same functionality but can be added to any view rather than just those > that extend it. > > It allows the target view to control the layer that's sliding out. For > toasts, that is the widget's layer. For notifications inside the message > center, that will continue to be the NotificationView itself. > > BUG=716429 > > Review-Url: https://codereview.chromium.org/2849523005 > Cr-Commit-Position: refs/heads/master@{#468339} > Committed: https://chromium.googlesource.com/chromium/src/+/3d7851ff607c370234e4f93ecf66727a8f8498d9 TBR=yoshiki@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716429 Review-Url: https://codereview.chromium.org/2850153003 Cr-Commit-Position: refs/heads/master@{#468394} Committed: https://chromium.googlesource.com/chromium/src/+/ba5c53c9efbb48cd5f54de19e996b24e63f511db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -274 lines) Patch
M ui/message_center/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/message_center/views/custom_notification_view_unittest.cc View 3 chunks +66 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/message_view.h View 7 chunks +10 lines, -18 lines 0 comments Download
M ui/message_center/views/message_view.cc View 7 chunks +13 lines, -15 lines 0 comments Download
M ui/message_center/views/message_view_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 7 chunks +44 lines, -67 lines 0 comments Download
D ui/message_center/views/slide_out_controller.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/message_center/views/slide_out_controller.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/views/controls/slide_out_view.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ui/views/controls/slide_out_view.cc View 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sky
Created Revert of CrOS: Fix appearance of notification toasts when sliding out via gesture
3 years, 7 months ago (2017-05-01 20:14:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850153003/1
3 years, 7 months ago (2017-05-01 20:15:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 20:16:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba5c53c9efbb48cd5f54de19e996...

Powered by Google App Engine
This is Rietveld 408576698