Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2850143003: Revert of [scheduler] Move some task types to suspendable task runner. (Closed)

Created:
3 years, 7 months ago by rnephew (Reviews Here)
Modified:
3 years, 7 months ago
Reviewers:
haraken, Sami, altimin
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Move some task types to suspendable task runner. (patchset #1 id:1 of https://codereview.chromium.org/2808273003/ ) Reason for revert: Causing telemetry test failures: https://bugs.chromium.org/p/chromium/issues/detail?id=717078&can=2&start=0&num=100&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=&hotlist_id= Original issue's description: > [scheduler] Move some task types to suspendable task runner. > > Move several safe-looking task types to suspendable task runner. > More task types will be moved to suspendable task runner, but > we'll start with this set and will monitor any problems > (there were some perfbot failures when all task queues were > moved to suspendable task runner). > > R=haraken@chromium.org > CC=skyostil@chromium.org > BUG=702160 > > Review-Url: https://codereview.chromium.org/2808273003 > Cr-Original-Commit-Position: refs/heads/master@{#464025} > Committed: https://chromium.googlesource.com/chromium/src/+/78a049660074003b8e1e602b0e7783ca7f1f4ee0 > Review-Url: https://codereview.chromium.org/2808273003 > Cr-Commit-Position: refs/heads/master@{#467633} > Committed: https://chromium.googlesource.com/chromium/src/+/c18764a33a595baab6ba35a1447e51c7c74b6e30 TBR=haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702160 Review-Url: https://codereview.chromium.org/2850143003 Cr-Commit-Position: refs/heads/master@{#468511} Committed: https://chromium.googlesource.com/chromium/src/+/0079dbad35b7fb64939a1c5ddc992084cc5001b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rnephew (Reviews Here)
Created Revert of [scheduler] Move some task types to suspendable task runner.
3 years, 7 months ago (2017-05-01 21:06:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850143003/1
3 years, 7 months ago (2017-05-01 21:07:39 UTC) #3
haraken
Interesting. LGTM to revert.
3 years, 7 months ago (2017-05-01 22:32:32 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 00:45:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0079dbad35b7fb64939a1c5ddc99...

Powered by Google App Engine
This is Rietveld 408576698