Settings reset prompt: Add a test for the default settings fetcher.

Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when fetching default settings fails.

BUG=716372
Review-Url: https://codereview.chromium.org/2850103002
Cr-Commit-Position: refs/heads/master@{#468424}
Committed: https://chromium.googlesource.com/chromium/src/+/45aeaf16b7bcce4ea13a322b3960ff1f4f3602b0

[alito, 2017-05-01 03:48:06]

Patchset #2 (id:20001) has been deleted

[alito, 2017-05-01 03:55:20]

Patchset #2 (id:40001) has been deleted

[alito, 2017-05-01 18:07:02]

Patchset #2 (id:60001) has been deleted

[alito, 2017-05-01 18:09:51]

Description was changed from

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

BUG=
==========

to

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when
fetching default settings fails.

BUG=
==========

[alito, 2017-05-01 18:13:19]

alito@chromium.org changed reviewers:
+ csharp@chromium.org, robertshield@chromium.org

[alito, 2017-05-01 18:13:19]

I've used a convenient way to inject fetching of default settings for testing.
PTAL!

[csharp, 2017-05-01 19:11:37]

lgtm

https://codereview.chromium.org/2850103002/diff/80001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h
(right):

https://codereview.chromium.org/2850103002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h:26:
// |BrandcodedDefaultSettings| object to |callback| on the UI thread. The
nit: The function -> This function (I think it makes it a bit clearer)

Also, should be -> must be?

[alito, 2017-05-01 19:18:19]

Thanks Chris. Robert?

https://codereview.chromium.org/2850103002/diff/80001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h
(right):

https://codereview.chromium.org/2850103002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h:26:
// |BrandcodedDefaultSettings| object to |callback| on the UI thread. The
On 2017/05/01 19:11:37, csharp wrote:
> nit: The function -> This function (I think it makes it a bit clearer)
> 
> Also, should be -> must be?

Done.

[robertshield, 2017-05-01 19:29:14]

quick thought pre-review: add bug number?

[alito, 2017-05-01 19:29:57]

Description was changed from

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when
fetching default settings fails.

BUG=
==========

to

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when
fetching default settings fails.

BUG=716372
==========

[alito, 2017-05-01 19:30:12]

On 2017/05/01 19:29:14, robertshield wrote:
> quick thought pre-review: add bug number?

Bug number added.

[robertshield, 2017-05-01 19:33:08]

lgtm

[alito, 2017-05-01 19:41:54]

The CQ bit was checked by alito@chromium.org

[alito, 2017-05-01 19:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2850103002/#ps100001
(title: "Nits")

[commit-bot: I haz the power, 2017-05-01 19:42:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 21:42:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493667714208750,
"parent_rev": "17a752635bbd60c652aea0fdf86ac1a58f17c870", "commit_rev":
"45aeaf16b7bcce4ea13a322b3960ff1f4f3602b0"}

[commit-bot: I haz the power, 2017-05-01 21:42:31]

Description was changed from

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when
fetching default settings fails.

BUG=716372
==========

to

==========
Settings reset prompt: Add a unit test for the default settings fetcher.

The test ensures that DefaultSettingsFetcher never returns null even when
fetching default settings fails.

BUG=716372

Review-Url: https://codereview.chromium.org/2850103002
Cr-Commit-Position: refs/heads/master@{#468424}
Committed:
https://chromium.googlesource.com/chromium/src/+/45aeaf16b7bcce4ea13a322b3960...
==========

[commit-bot: I haz the power, 2017-05-01 21:42:32]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/45aeaf16b7bcce4ea13a322b3960...